Report output #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
theztefan
commented
Dec 28, 2022
theztefan
commented
- Fix: report in JSON format to be uploaded as artifact.
- Options to configure the report format: JSON, PDF
gateixeira
reviewed
Dec 28, 2022
| @@ -8,16 +8,20 @@ inputs: | |||
| default: srdemo-demo | |||
| org: | |||
| description: "The organisation to generate the report for" | |||
| required: false | |||
| required: true | |||
There was a problem hiding this comment.
is there a reason why you changed these fields to required: true but still kept the default value?
There was a problem hiding this comment.
Yep, I thought of you when I changed this. 😄
| @@ -127,6 +129,197 @@ export function prepareSummary(report: Report): void { | |||
| ]); | |||
| } | |||
|
|
|||
| export function preparePdf(report: Report): jsPDF { | |||
There was a problem hiding this comment.
have you considered making it a bit more generic to generate the reports? It is repeating a lot of data between JSON and PDF
There was a problem hiding this comment.
Well one function was preparing and writing markdown using core.summary and the other one is preprating a jsPDF() object. The object is then passed to be written to a file.
That is the only difference. The data is very much the same. There should be a more generic way to do this but didn't get to it in this iteration.
gateixeira
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.