Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make data parsers return null when empty string is passed #49

Closed
thiagolvlsantos opened this issue Apr 25, 2016 · 2 comments
Closed

Make data parsers return null when empty string is passed #49

thiagolvlsantos opened this issue Apr 25, 2016 · 2 comments
Assignees
@thiagolvlsantos
Labels
enhancement
Milestone
1.4.68

Comments

@thiagolvlsantos
Copy link
Owner

java.text.ParseException: Unparseable date: ""
at java.text.DateFormat.parse(DateFormat.java:357)
at org.specrunner.converters.core.ConverterDatePatternArgs.convert(ConverterDatePatternArgs.java:67)
at org.specrunner.util.xom.node.core.NodeHolderDefault.getLocal(NodeHolderDefault.java:447)
at org.specrunner.util.xom.node.core.NodeHolderDefault.getObject(NodeHolderDefault.java:414)
at org.specrunner.util.xom.node.core.NodeHolderDefault.getObject(NodeHolderDefault.java:409)
@thiagolvlsantos thiagolvlsantos self-assigned this Apr 25, 2016
@thiagolvlsantos thiagolvlsantos added this to the 1.4.68 milestone Apr 25, 2016
@thiagolvlsantos
Copy link
Owner Author

Check if 'accept' should not be called before try to convert. Looks like '.getValue(...)' is missing this requirement.

@thiagolvlsantos
Copy link
Owner Author

thiagolvlsantos commented Apr 26, 2016 •
edited
Loading

The getValue was changed to convert only if converter accepts the provided value.

thiagolvlsantos added a commit that referenced this issue Apr 27, 2016
@thiagolvlsantos
Make data parsers return null when empty string is passed #49
2415f8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thiagolvlsantos thiagolvlsantos

Labels
enhancement
Projects
None yet
Milestone
1.4.68
Development

No branches or pull requests
1 participant
@thiagolvlsantos