Systemd on-demand socket-based activation #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Creates php::fpm::systemd-socket-conf for systemd sockets * Adds systemd socket and service * Modified config file templates that allow for multiple php-fpm master processes.
The socket starts the service as needed. Enabling it in puppet can cause a race condition where the service tries to start before the socket exists.
The PID directory only needs to be created once and including it in the systemd-socket-conf will attempt to define it multiple times if multiple pools are defined. Moving it to a daemon manifest so it only happens once.
Move systemd service path into params.pp Add binary to params.pp Make service template use binary parameter
Puppet on Debian wants to call 'service' instead of 'systemctl'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides support for creating systemd socket-based activation of on-demand PHP-FPM daemons.
Defines
php::fpm::systemd-socket-confthat will create the corresponding systemd.socketand.serviceconfigurations. Multiple pools may be created using separate sockets/services so that rolling, zero-downtime restarts of PHP-FPM may be accomplished.Tested on CentOS7 and Debian Jessie.
Based heavily on http://thanatos.be/2014/04/12/php-fpm-ondemand.html