Add support for new type of youtube thumbnail and add missing tests f… #192
Conversation
…or maxres and large thumbnails to non-youtube providers
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
| @@ -3,6 +3,7 @@ | |||
| [nil, 'AIzaSyA6PYwSr1EnLFUFy1cZDk3Ifb0rxeJaeZ0'].each do |api_key| | |||
| describe VideoInfo::Providers::YoutubePlaylist do | |||
| before(:each) do | |||
| #TODO: I think this is unnecessary. Should be removed? | |||
There was a problem hiding this comment.
@thibaudgg What do you think of this? I'm pretty sure since we pass in the api key we don't need to set it. Since the tests dont run in my repo tho didn't want to remove this since I can't reliable run the whole test suite.
There was a problem hiding this comment.
Yeah that's weird, or the [nil, 'AIzaSyA6PYwSr1EnLFUFy1cZDk3Ifb0rxeJaeZ0'].each do |api_key| loop could be removed as well, doesn't make sense to test twice the same thing. 🤔
There was a problem hiding this comment.
Let me know what you'd like! If possible hoping to get this merged sometime soon as I'm hoping to use it for another project. Really appreciate your fast reply and helping me through these changes thus far!
There was a problem hiding this comment.
I would remove [nil, 'AIzaSyA6PYwSr1EnLFUFy1cZDk3Ifb0rxeJaeZ0'].each do |api_key|, no reason to test two times the same things. 👍
There was a problem hiding this comment.
@thibaudgg removed!
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
|
@thibaudgg This is ready for review as well. |
| @@ -3,6 +3,7 @@ | |||
| [nil, 'AIzaSyA6PYwSr1EnLFUFy1cZDk3Ifb0rxeJaeZ0'].each do |api_key| | |||
| describe VideoInfo::Providers::YoutubePlaylist do | |||
| before(:each) do | |||
| #TODO: I think this is unnecessary. Should be removed? | |||
There was a problem hiding this comment.
Yeah that's weird, or the [nil, 'AIzaSyA6PYwSr1EnLFUFy1cZDk3Ifb0rxeJaeZ0'].each do |api_key| loop could be removed as well, doesn't make sense to test twice the same thing. 🤔
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
This addresses #191 (comment)