Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix youtube specs and attributes #195

Merged
merged 8 commits into from
Sep 6, 2020

Conversation

joaocv3
Copy link
Collaborator

@joaocv3 joaocv3 commented Sep 6, 2020

  • Changed all necessary attributes for youtube scrapper. All attributes accessed via CSS are no longer available
  • All HTTP interactions for youtube_spec and youtube_scrapper_spec use VCR now, the API_KEY does not need to be committed anymore.
  • Updated the Guard Rspec cmd option
  • Very little channel information is provided for the Youtube scraper video request. So these changes add one request for the youtube channel endpoint when necessary.

Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.912% when pulling 4edc14d on joaocv3:fix-youtube-specs into 9cd9700 on thibaudgg:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.912% when pulling 4edc14d on joaocv3:fix-youtube-specs into 9cd9700 on thibaudgg:master.

@thibaudgg
Copy link
Owner

Hi @joaocv3, this PR looks great! Thanks a lot, that's really promising! 👍

@thibaudgg thibaudgg merged commit 758dda3 into thibaudgg:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants