Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wistia specs #199

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Fix wistia specs #199

merged 3 commits into from
Oct 2, 2020

Conversation

joaocv3
Copy link
Collaborator

@joaocv3 joaocv3 commented Oct 2, 2020

  • Update Wistia VCR cassetes
  • Use VCR cassetes for all Wistia specs
  • Fix Wistia duration spec

Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c84e095 on joaocv3:fix-wistia-specs into eba0e8c on thibaudgg:master.

@thibaudgg
Copy link
Owner

🎉

@thibaudgg thibaudgg merged commit ca3b1fc into thibaudgg:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants