Drop ruby 2.4 support/ Config Github Actions #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaocv3
force-pushed
the
drop-ruby-2.4-support
branch
8 times, most recently
from
c8c3a2a to
e19ba09
Compare
joaocv3
force-pushed
the
drop-ruby-2.4-support
branch
from
e19ba09 to
f898e6c
Compare
joaocv3
changed the title
thibaudgg
reviewed
Oct 30, 2020
Co-authored-by: Thibaud Guillaume-Gentil <thibaud@thibaud.gg>
|
@joaocv3 one point that I missed, could you please also update the build status page in the README, Github provides one as well. [](https://github.com/thibaudgg/video_info/actions?query=workflow%3A%22Ruby+Unit+Tests%22) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @thibaudgg :)
The new actions cannot be run directly here yet.
So you can check those changes working here: joaocv3#2 (it's the same branch)
What do you think?