-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use String#match? for speed in 'usable?' helper #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the CI update. 👍 Just one comment.
104 examples, 24 failures in 42.5583 seconds | ||
./spec/lib/video_info/providers/dailymotion_spec.rb:134 | ||
./spec/lib/video_info/providers/dailymotion_spec.rb:139 | ||
./spec/lib/video_info/providers/dailymotion_spec.rb:144 | ||
./spec/lib/video_info/providers/dailymotion_spec.rb:159 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:108 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:115 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:120 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:128 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:133 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:138 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:143 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:152 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:158 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:164 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:180 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:197 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:202 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:207 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:212 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:308 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:309 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:310 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:311 | ||
./spec/lib/video_info/providers/vimeo_spec.rb:54 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should git ignore that file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 👉🏼 261c0bf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
Closes #209
Since part of the build is broken, you can test these changes by running only the
usable?
related specs:All those specs passes ✅
EXTRAS
unit_test.yml
CI workflow with new actions and new Ruby versions. The build is still broken, but at least now it runs on CI, so we have an idea (ℹ️ 409 examples, 64 failures) and it will be useful to fix them.tmp/rspec_guard_result
)