🛠️ Fix specs and update deps #211

markets · 2023-02-09T21:24:08Z

Dailymotion
Wistia
Youtube
YoutubePlaylist
Vimeo
Remove debugging commits (c540e6d, a575dcc)
Make CI green (all passes ✅ locally) => maybe in new PR How to use environment secret on github action? actions/starter-workflows#785 (comment)?

EXTRAS

Update runtime deps:
- iso8601 from '0.9.1' to '0.13.0'
- oga from '3.0' to '3.4'
- net_http_timeout_errors from '0.3.0' to '1.0.0'
Update to latest VCR (from '3.0' to '6.1')
Clean up gemspec and Gemfile
Minor docs tweaks (basically Markdown format)

… Wistia

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

markets · 2023-02-09T21:29:13Z

@thibaudgg I started some work! Dailymotion, Wistia and Vimeo scraper are fully passing now ✔️

To continue with Vimeo and Youtube I need I think those API keys. Do we have some keys for testing 🙏🏼? I'd like to avoid creating accounts and setup apps in each service 😅. The CI (or any other contributor) will need them anyway, so probably we need to think a more comfortable solution for that. How did you do it in the past?

thibaudgg · 2023-02-10T08:08:23Z

@thibaudgg I started some work! Dailymotion and Wistia are fully passing now.

Awesome! 🙌🏻

To continue with Vimeo and Youtube I need I think those API keys. Do we have some keys for testing 🙏🏼? I'd like to avoid creating accounts and setup apps in each service 😅. The CI (or any other contributor) will need them anyway, so probably we need to think a more comfortable solution for that. How did you do it in the past?

Good question, I wasn't able to find back the YOUTUBE_API_KEY and VIMEO_ACCESS_TOKEN that I was using in the past 🙈. It would be great if you could create new test accounts for those two, ensure these credentials aren't present in the VCR (you can filter sensitive data) cassettes and then send me privately your keys so I can set them on the repo secret actions variables. What do you think about this setup?

Gemfile

markets · 2023-02-10T20:58:03Z

What do you think about this setup?

Not really like it, because any contributor will need those keys to be able to run the tests... but I don't have any other proposal right now :)

Since those keys are just for testing purposes, probably we can just share them with very low risk.

To be honest, I'm very lazy about creating those keys 😅... I'd like to finish this task and send some other small improvements to the project, but if someone can provide me a couple of keys that would help me a lot 👌🏼 maybe @joaocv3 (last maintainer that touched those files) have some valid keys 🙏🏼?

joaocv3 · 2023-02-12T19:07:39Z

Hey @markets! I actually still have them 🙏

I'll email them to you and Thibaud.

I like the ideia of having project keys for future maintainers though. I will create a Google account and keys for the project as soon as I have some time.

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

…p-ruby step

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

markets · 2023-02-20T19:08:27Z

Only 1 spec failing (related to Vimeo API)!

Failures:

  1) VideoInfo::Providers::Vimeo with video 136971428 #view_count is expected to be > 80
     Failure/Error: it { is_expected.to be > 80 }
     
       expected: > 80
            got:   0
     # ./spec/lib/video_info/providers/vimeo_spec.rb:210:in `block (5 levels) in <top (required)>'

Finished in 17.98 seconds (files took 1.15 seconds to load)
409 examples, 1 failure, 2 pending

It seems the API doesn't return this data (you can try it here: https://developer.vimeo.com/api/reference/videos#get_video with this video id 136971428) anymore ...

"stats": { "plays": null }

From what I'm reading on some issues, I think we should change some configuration in the used API key:

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

starting to fix specs: regenerate VCR cassettes + fix Dailymotion and…

14d6ed7

… Wistia

houndci-bot reviewed Feb 9, 2023

View reviewed changes

markets changed the title ~~[WIP] Fix specs~~ 🛠️ Fix specs Feb 9, 2023

markets commented Feb 10, 2023

View reviewed changes

Gemfile Outdated Show resolved Hide resolved

fix youtube specs

c81970a

houndci-bot reviewed Feb 15, 2023

View reviewed changes

markets added 2 commits February 15, 2023 21:05

Merge branch 'master' into fix_specs

9b54f8f

[ci] setup ENV vars globally, now they are just accesible in the setu…

04c5225

…p-ruby step

houndci-bot reviewed Feb 15, 2023

View reviewed changes

clean up gemspec and Gemfile

c18c138

houndci-bot reviewed Feb 15, 2023

View reviewed changes

regenerate vcr_cassettes + minor docs tweaks

bb106ef

houndci-bot reviewed Feb 15, 2023

View reviewed changes

[specs] try with master cassettes

fad9963

houndci-bot reviewed Feb 15, 2023

View reviewed changes

[deps] update VCR to latest version

fe1d983

houndci-bot reviewed Feb 19, 2023

View reviewed changes

[deps] update runtime deps

35e0b98

houndci-bot reviewed Feb 19, 2023

View reviewed changes

markets changed the title ~~🛠️ Fix specs~~ 🛠️ Fix specs and update deps Feb 19, 2023

[specs] properly re-do Vimeo cassettes

55075b3

houndci-bot reviewed Feb 20, 2023

View reviewed changes

[specs] more stable youtube spec (view_count changes over the time)

7291abb

houndci-bot reviewed Feb 20, 2023

View reviewed changes

[specs] regenerate vimeo vcr cassettes with new key

e8ee4fa

houndci-bot reviewed Feb 21, 2023

View reviewed changes

houndci-bot reviewed Feb 22, 2023

View reviewed changes

houndci-bot reviewed Feb 23, 2023

View reviewed changes

markets marked this pull request as ready for review February 23, 2023 10:18

thibaudgg merged commit 6f63e82 into thibaudgg:master Feb 23, 2023

markets deleted the fix_specs branch February 23, 2023 11:28

markets mentioned this pull request Mar 6, 2023

[specs] more up-to-date view_count values #218

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🛠️ Fix specs and update deps #211

🛠️ Fix specs and update deps #211

markets commented Feb 9, 2023 •

edited

Loading

houndci-bot left a comment

markets commented Feb 9, 2023 •

edited

Loading

thibaudgg commented Feb 10, 2023

markets commented Feb 10, 2023 •

edited

Loading

joaocv3 commented Feb 12, 2023

houndci-bot left a comment

houndci-bot left a comment

houndci-bot left a comment

houndci-bot left a comment

houndci-bot left a comment

houndci-bot left a comment

houndci-bot left a comment

houndci-bot left a comment

houndci-bot left a comment

markets commented Feb 20, 2023

houndci-bot left a comment

houndci-bot left a comment

houndci-bot left a comment

houndci-bot left a comment

🛠️ Fix specs and update deps #211

🛠️ Fix specs and update deps #211

Conversation

markets commented Feb 9, 2023 • edited Loading

houndci-bot left a comment

Choose a reason for hiding this comment

markets commented Feb 9, 2023 • edited Loading

thibaudgg commented Feb 10, 2023

markets commented Feb 10, 2023 • edited Loading

joaocv3 commented Feb 12, 2023

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

markets commented Feb 20, 2023

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

markets commented Feb 9, 2023 •

edited

Loading

markets commented Feb 9, 2023 •

edited

Loading

markets commented Feb 10, 2023 •

edited

Loading