Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Rubocop to Standard #213

Merged
merged 9 commits into from
Feb 25, 2023
Merged

Migrate from Rubocop to Standard #213

merged 9 commits into from
Feb 25, 2023

Conversation

markets
Copy link
Collaborator

@markets markets commented Feb 24, 2023

StandardRB Ruby Style Guide, with linter & automatic code fixer

WHY?
https://github.com/testdouble/standard#why-should-i-use-ruby-standard-style

EXTRAS

  • Migrate from Hound to GH Actions

@markets
Copy link
Collaborator Author

markets commented Feb 24, 2023

@thibaudgg not sure why the amoeba/standardrb-action failed 🤔, StandardRB Linter passes for me locally ✅

So for now, I just added the linter as an extra step calling manually bundle exec standardrb. We won't have comments reporting in pull requests, but this is fine for me too 😃 we can integrate an action later in case we miss them?

@markets markets marked this pull request as ready for review February 24, 2023 22:13
@thibaudgg
Copy link
Owner

@markets I would try to fix it, it's nice to have the comments directly in the pull requests.

Did you already try to fix the permissions? https://github.com/marketplace/actions/standardrb#common-issues

@markets
Copy link
Collaborator Author

markets commented Feb 25, 2023

Thanks @thibaudgg! Defining the permissions was the trick:

permissions:
  checks: write
  contents: read

Copy link
Owner

@thibaudgg thibaudgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

- [João Vieira](https://github.com/joaocv3) ([@joaocv3](https://github.com/joaocv3))
- [Vincent Heuken](https://github.com/vheuken)
- [João Vieira](https://github.com/joaocv3)
- [Marc Anguera](https://github.com/markets)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! 🙌🏻

@markets markets merged commit d04aaef into master Feb 25, 2023
@markets markets deleted the linter_improvements branch February 25, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants