-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Rubocop to Standard #213
Conversation
Migrate from Rubocop to Standard
5d97347
to
9cf46ab
Compare
@thibaudgg not sure why the So for now, I just added the linter as an extra step calling manually |
@markets I would try to fix it, it's nice to have the comments directly in the pull requests. Did you already try to fix the permissions? https://github.com/marketplace/actions/standardrb#common-issues |
Thanks @thibaudgg! Defining the permissions was the trick:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
- [João Vieira](https://github.com/joaocv3) ([@joaocv3](https://github.com/joaocv3)) | ||
- [Vincent Heuken](https://github.com/vheuken) | ||
- [João Vieira](https://github.com/joaocv3) | ||
- [Marc Anguera](https://github.com/markets) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! 🙌🏻
StandardRB
Ruby Style Guide, with linter & automatic code fixerWHY?
https://github.com/testdouble/standard#why-should-i-use-ruby-standard-style
EXTRAS