Fix embed urls : now complete (http and https wide)

[tibastral]

No description provided.

[thibaudgg]

Specs? 🙏

[tibastral]

Les specs passent :)

& BTW, j’aime beaucoup ton jeux de tests avec les Rémi Gaillard, etc.

Et aussi, je trouve ton travail super, et je t’en remercie du fond du coeur !

• Thibaut
  freelancebooking.pro creator

On 3 Apr 2014 at 11:13:12, Thibaud Guillaume-Gentil (notifications@github.com) wrote:

Specs?

—
Reply to this email directly or view it on GitHub.

[karlentwistle]

This PR is a great idea!

However in its current form. There doesn't seem to be any point in hanging onto

url_scheme: 'https

As in

expect(provider.embed_code(url_scheme: 'https')).to eq ......

[tibastral]

Agreed

• Thibaut
  freelancebooking.pro creator

On 3 Apr 2014 at 11:53:01, Thibaut Assus (thibaut@milesrock.com) wrote:

Les specs passent :)

& BTW, j’aime beaucoup ton jeux de tests avec les Rémi Gaillard, etc.

Et aussi, je trouve ton travail super, et je t’en remercie du fond du coeur !

• Thibaut
  freelancebooking.pro creator

On 3 Apr 2014 at 11:13:12, Thibaud Guillaume-Gentil (notifications@github.com) wrote:

Specs?

—
Reply to this email directly or view it on GitHub.

[karlentwistle]

I wonder if any current users would be relying on url_scheme returning a specific protocol other than the one they're already using.

For example

• http website specifically opts for https
• https website specifically opts for http

[tibastral]

When you are on https, you want to have everything in https.

When you are on http, you don’t care about https

Look at that vimeo link to integrate urls : http://developer.vimeo.com/player/embedding

• Thibaut
  freelancebooking.pro creator

On 3 Apr 2014 at 15:55:33, Karl Entwistle (notifications@github.com) wrote:

I wonder if any current users would be relying on url_scheme returning a specific protocol other than the one they're already using.

For example

http website specifically opts for https
https website specifically opts for http
—
Reply to this email directly or view it on GitHub.

[thibaudgg]

@karlentwistle I agree, good point.
@tibastral could you please clean every url_scheme logic? Thanks!

[tibastral]

done

• Thibaut
  freelancebooking.pro creator

On 3 Apr 2014 at 16:01:37, Thibaud Guillaume-Gentil (notifications@github.com) wrote:

@karlentwistle I agree, good point.
@tibastral could you please clean every url_scheme logic? Thanks!

—
Reply to this email directly or view it on GitHub.

[thibaudgg]

Thanks all, 2.3.1 released!

[tibastral]

genius :)

• Thibaut
  freelancebooking.pro creator

On 3 Apr 2014 at 16:39:51, Thibaud Guillaume-Gentil (notifications@github.com) wrote:

Thanks all, 2.3.1 released!

—
Reply to this email directly or view it on GitHub.

[karlentwistle]

Nice one tibastral 👍

[tibastral]

<3

• Thibaut
  freelancebooking.pro creator

On 3 Apr 2014 at 17:16:51, Karl Entwistle (notifications@github.com) wrote:

Nice one tibastral

—
Reply to this email directly or view it on GitHub.

[thibaudgg]

😍