Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vimeo Channels #58

Merged
merged 1 commit into from
Nov 12, 2014
Merged

Conversation

0mega
Copy link
Contributor

@0mega 0mega commented Nov 12, 2014

Added support for URLs like:
http://vimeo.com/channels/[channel_name]/[video_id]

I need support for this while using link_thumbnailer gem
which in turn uses this one

@@ -41,7 +41,7 @@ def _video
end

def _url_regex
/.*\.com\/(?:(?:groups\/[^\/]+\/videos\/)|(?:ondemand\/less\/)|(?:video\/))?([0-9]+).*$/
/.*\.com\/(?:(?:groups\/[^\/]+\/videos\/)|(?:ondemand|channels)(?:(?:\/less\/)|(?:\/\w*\/))|(?:video\/))?([0-9]+).*$/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [125/80]

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) when pulling a8d1ee3 on 0mega:vimeo_channels into 2c71c06 on thibaudgg:master.

@thibaudgg
Copy link
Owner

Thanks!

thibaudgg added a commit that referenced this pull request Nov 12, 2014
Add support for Vimeo Channels
@thibaudgg thibaudgg merged commit a1eb9da into thibaudgg:master Nov 12, 2014
@thibaudgg
Copy link
Owner

2.3.3 released

@0mega 0mega deleted the vimeo_channels branch November 12, 2014 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants