Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Link-Time Optimization (LTO) #16

Closed
zamazan4ik opened this issue Nov 5, 2024 · 1 comment · Fixed by #17
Closed

Enable Link-Time Optimization (LTO) #16

zamazan4ik opened this issue Nov 5, 2024 · 1 comment · Fixed by #17
Assignees
Labels
enhancement New feature or request

Comments

@zamazan4ik
Copy link

Hi!

I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.

I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where in addition to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the application with cargo install, will get the LTO-optimized version "automatically". E.g., check cargo-outdated Release profile.

Basically, it can be enabled with the following lines:

[profile.release]
lto = true

I have made quick tests (Fedora 41, Rustc 1.82) by adding lto = true to the Release profile. The binary size reduction is from 14 Mib to 8.7 Mib.

Thank you.

@thibaultmeyer thibaultmeyer added the enhancement New feature or request label Nov 5, 2024
@thibaultmeyer thibaultmeyer self-assigned this Nov 5, 2024
thibaultmeyer added a commit that referenced this issue Nov 5, 2024
Resolves: #16
Signed-off-by: Thibault Meyer <meyer.thibault@gmail.com>
@thibaultmeyer
Copy link
Owner

Thank you for your suggestion for improvement. I think it's a good idea.

@thibaultmeyer thibaultmeyer linked a pull request Nov 5, 2024 that will close this issue
thibaultmeyer added a commit that referenced this issue Nov 5, 2024
Resolves: #16

Signed-off-by: Thibault Meyer <meyer.thibault@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants