-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello, macOS. 👋 #245
base: master
Are you sure you want to change the base?
Hello, macOS. 👋 #245
Conversation
…+ UI unit tests, & other unit tests.
Hi Chris I have an issue #249, from a problem I saw with Mac Catalyst (another approach to building a Mac App). Can you check if the unit test code that I included in my issue works with your changes. If it doesn't then I have a fix that doesn't rely on UIFont tracking font names Cheers |
Got it 👍! Good looks on the Mac Catalyst stuff though. Most of the AppKit goodies are purposefully left out, for now... |
Honestly this looks pretty good. I want to merge but there’s a few things on the iOS side I want to refactor first before we pull this in. Hang tight, I love this! |
Fantastic! |
It looks like a lot... & it is, but no preexisting code has been modified (aside from the occasional minimal refactoring). In general, I added macOS cross-platform compatibility, a macOS demo app + UI unit tests, & other unit tests.
You may notice that the UIKit-flavored objects do not get some of the new features like conformance to
FontAwesomeRepresentable
. This was entirely to avoid making any systemic modifications to the UIKit-platform code. Such features can easily be integrated into the UIKit-platform code at any point, should one want.Comments, questions, or concerns?