-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ci): reduce PR test report output by hiding passed tests #2134
test(ci): reduce PR test report output by hiding passed tests #2134
Conversation
Robot Results
Passed Tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
LGTM
The full report is still visible in the test runner, but hiding the passed tests helps reduce the noise in PRs Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
f25c23c
to
055e3ce
Compare
After investigating why the "Passed tests" was still visible in this PR, it was found that the PR checks executed on the PR itself are from the main branch and not from the current PR's branch, therefore the settings which control the visibility of the "Passed Tests" section will not be in-effect until it is merged into main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Proposed changes
The full report is still visible in the test runner, but hiding the passed tests helps reduce the noise in PRs.
For example, the "Passed tests" section will be left out of the comment posted after the integration tests have passed. Below shows an example of how the section was previously included by default, and with ~240 tests, it made scrolling through the PR very difficult.
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments