Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MSRV to 1.54.0 #384

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Bump MSRV to 1.54.0 #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccff4fc
Bump MSRV to 1.54.0
rina23q Aug 13, 2021
04e459f
Change also in post merge workflow
rina23q Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/commit-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,10 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Install rust v1.51.0
- name: Install rust v1.54.0
uses: actions-rs/toolchain@v1
with:
toolchain: "1.51.0"
toolchain: "1.54.0"
override: true

- name: Enable cache
Expand All @@ -130,7 +130,7 @@ jobs:
# https://github.com/marketplace/actions/rust-cargo
with:
command: tarpaulin
args: -v --out Xml
args: --avoid-cfg-tarpaulin -v --out Xml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you say why this is necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, tarpaulin gives an error to bitvec 0.19.5 if the toolchain version is 1.52 or higher. People reported this in xd009642/tarpaulin#756, and the solution is to add the argument.


- name: Upload to codecov.io
uses: codecov/codecov-action@v1
Expand Down Expand Up @@ -197,4 +197,4 @@ jobs:
# https://github.com/marketplace/actions/rust-cargo
with:
command: msrv
args: --minimum 1.51.0
args: --minimum 1.54.0
2 changes: 1 addition & 1 deletion .github/workflows/hosted-post-merge_version_update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: enable toolchain via github action
uses: actions-rs/toolchain@v1
with:
toolchain: 1.51
toolchain: 1.54
components: cargo
override: true

Expand Down
4 changes: 2 additions & 2 deletions BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ And then you can run `rustc` to view current version:

```shell
$ rustc --version
rustc 1.51.0 (2fd73fabe 2021-03-23)
rustc 1.54.0 (a178d0322 2021-07-26)
```

> Note: Above command will add rust to path only for existing session,
Expand All @@ -62,7 +62,7 @@ rustc 1.51.0 (2fd73fabe 2021-03-23)

thin-edge.io operates the `MSRV` (Minimum Supported Rust Version) and uses stable toolchain.

Current MSRV is `1.51.0`.
Current MSRV is `1.54.0`.

### Cross compilation toolchain (optional)

Expand Down