[BREAKING] Change Monorepo tool to Turborepo #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
test release workflow test release workflow test release workflow test release workflow test release workflow test release workflow test release workflow test release workflow test release workflow test release workflow test release workflow test release workflow test release workflow test release workflow
saenyakorn
force-pushed
the
yu/breaking/change-monorepo-tools
branch
from
4a7ef4f
to
eca528e
Compare
This reverts commit c5127c4.
|
ดูจาก repo GitOps แล้วคิดว่าน่าจะต้องแก้วิธีใส่ version ใหม่ เดี๋ยว merge อันนี้ไปก่อน แล้วเดี๋ยว เปิด PR ไปยัง repo GitOps ตอน deploy เดี๋ยวมาอีกที |
suphon-t
reviewed
Feb 2, 2023
| @@ -23,7 +23,7 @@ FROM pnpm AS installer | |||
| WORKDIR /app | |||
|
|
|||
| COPY --from=builder /app/out/json/ . | |||
| COPY --from=builder /app/out/pnpm-lock.yaml ./pnpm-lock.yaml | |||
| COPY pnpm-lock.yaml ./pnpm-lock.yaml | |||
There was a problem hiding this comment.
Why are we no longer using pruned lock file?
There was a problem hiding this comment.
because sometimes turbo incorrectly prunes the file and remove some files we need (e.g. mongoose and shit) vercel/turborepo#2791
There was a problem hiding this comment.
i figure it's fine if we use the full lockfile, since we pruned the package json anyways?
There was a problem hiding this comment.
Huh, it looks fine over here. No missing modules.
There was a problem hiding this comment.
can you try using pruned pnpm-lock and build reg-scraper image?
suphon-t
reviewed
Feb 2, 2023
saenyakorn
commented
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why did you create this PR
What I'm planning to do
project.jsonandnx.jsonpnpm-lock.yamlpackage.jsonfor each app and package withname,version, and general script likedev,build,lintpnpm-lock.yaml, and install external package with specific version for each app and packages.Done
Demo
No demo yet
Checklist
Related links
Resource https://github.com/saenyakorn/turborepo-versioning-demo/
Notes
I'll continuously update the progress. And I'll ready for review when I'm fully sure that our apps can be built and run properly.