Skip to content

Commit

Permalink
[Fix] Runnect#178 - 코드 리뷰 일부 반영
Browse files Browse the repository at this point in the history
  • Loading branch information
thingineeer committed Sep 13, 2023
1 parent 542de47 commit 11e761d
Show file tree
Hide file tree
Showing 17 changed files with 11 additions and 86 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -111,4 +111,5 @@ iOSInjectionProject/
Config.swift
Gemfile.lock
report.xml
Runnect-iOS/fastlane/.env.default
Runnect-iOS/fastlane/.env.default
GoogleService-Info.plist
1 change: 1 addition & 0 deletions Runnect-iOS/Runnect-iOS.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1623,6 +1623,7 @@
INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad = "UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight";
INFOPLIST_KEY_UISupportedInterfaceOrientations_iPhone = "UIInterfaceOrientationPortrait UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight";
INFOPLIST_KEY_UIUserInterfaceStyle = Light;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down
2 changes: 0 additions & 2 deletions Runnect-iOS/Runnect-iOS/Global/Literal/ImageLiterals.swift
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ enum ImageLiterals {
static var icFollowButton: UIImage {.load(named: "ic_follow_button")}
static var icFollowedButton: UIImage {.load(named: "ic_followed_button")}
static var icShareButton: UIImage {.load(named: "ic_share")}
static var icSelectMapButton: UIImage {.load(named: "ic_select_map")}
static var icSelectNowButton: UIImage {.load(named: "ic_select_now")}

// img
static var imgBackground: UIImage { .load(named: "img_background") }
Expand Down

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.
3 changes: 0 additions & 3 deletions Runnect-iOS/Runnect-iOS/Global/Supports/AppDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,8 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
var window: UIWindow?

func scene(_ scene: UIScene, openURLContexts URLContexts: Set<UIOpenURLContext>) {

print("🔥AppDelegate 의 openURLContexts 입니다 \n🔥")
if let url = URLContexts.first?.url {


if (AuthApi.isKakaoTalkLoginUrl(url)) {
_ = AuthController.handleOpenUrl(url: url)
}
Expand Down
13 changes: 7 additions & 6 deletions Runnect-iOS/Runnect-iOS/Global/Supports/SceneDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -68,30 +68,31 @@ class SceneDelegate: UIResponder, UIWindowSceneDelegate {

func scene(_ scene: UIScene, openURLContexts URLContexts: Set<UIOpenURLContext>) {

print("🔥 scene openURLContexts 지점")
if let url = URLContexts.first?.url {
// Firebase Dynamic Links를 사용하여 딥 링크를 처리합니다.
let linkHandled = DynamicLinks.dynamicLinks()
.handleUniversalLink(url) { dynamicLink, error in

if let courseId = self.handleDynamicLink(dynamicLink) {
guard let _ = (scene as? UIWindowScene) else { return }

if let windowScene = scene as? UIWindowScene {
let window = UIWindow(windowScene: windowScene)

let courseDetailVC = CourseDetailVC()
courseDetailVC.setPublicCourseId(publicCourseId: Int(courseId))
courseDetailVC.getUploadedCourseDetail(courseId: Int(courseId))

let tabBarController = TabBarController()
let navigationController = UINavigationController(rootViewController: tabBarController)
navigationController.navigationBar.isHidden = true
navigationController.pushViewController(courseDetailVC, animated: false)

window.rootViewController = navigationController
window.makeKeyAndVisible()
self.window = window

}
}
}
Expand Down
1 change: 0 additions & 1 deletion Runnect-iOS/Runnect-iOS/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
<key>CFBundleURLSchemes</key>
<array>
<string>kakao27d01e20b51e5925bf386a6c5465849f</string>
<string>runnect</string>
</array>
</dict>
<dict>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import FirebaseDynamicLinks
import KakaoSDKShare
import KakaoSDKTemplate


final class CourseDetailVC: UIViewController {

// MARK: - Properties
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,6 @@ final class DepartureSearchVC: UIViewController {
$0.backgroundColor = .g5
}

private let selectNowButton = UIButton(type: .custom).then {
$0.setImage(ImageLiterals.icSelectNowButton, for: .normal)
$0.tintColor = .g1
}

private let selectMapButton = UIButton(type: .custom).then {
$0.setImage(ImageLiterals.icSelectMapButton, for: .normal)
$0.tintColor = .g3
}

private let locationTableView = UITableView(frame: .zero, style: .plain).then {
$0.backgroundColor = .white
$0.separatorStyle = .none
Expand Down Expand Up @@ -102,7 +92,7 @@ extension DepartureSearchVC {
}

private func setLayout() {
view.addSubviews(naviBar, dividerView, locationTableView, selectNowButton, selectMapButton)
view.addSubviews(naviBar, dividerView, locationTableView)

naviBar.snp.makeConstraints { make in
make.leading.top.trailing.equalTo(view.safeAreaLayoutGuide)
Expand All @@ -115,17 +105,6 @@ extension DepartureSearchVC {
make.height.equalTo(6)
}

selectNowButton.snp.makeConstraints { make in
make.top.equalTo(dividerView.snp.bottom)
make.height.equalTo(40)
}

selectMapButton.snp.makeConstraints { make in
make.top.equalTo(dividerView.snp.bottom)
make.leading.equalTo(selectNowButton.snp.trailing)
make.height.equalTo(40)
}

locationTableView.snp.makeConstraints { make in
make.top.equalTo(dividerView.snp.bottom)
make.leading.bottom.trailing.equalTo(view.safeAreaLayoutGuide)
Expand Down Expand Up @@ -178,9 +157,6 @@ extension DepartureSearchVC: UITableViewDelegate, UITableViewDataSource {
extension DepartureSearchVC: CustomNavigationBarDelegate {
func searchButtonDidTap(text: String) {
searchAddressWithKeyword(keyword: text)
// 검색 바 입력 시 버튼 숨김 처리
selectNowButton.isHidden = true
selectMapButton.isHidden = true
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,4 @@ extension TabBarController {
return nav
}


}

0 comments on commit 11e761d

Please sign in to comment.