Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DevicePublishMsg processing to eliminate unnecessary transformation to PublishMsg #178

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

ShvaykaD
Copy link
Contributor

Pull Request description

This PR refactors the processing logic for persisted publish messages for DEVICE clients to remove the conversion step from DevicePublishMsg to PublishMsg class before sending the message to the publish delivery service. Previously, DevicePublishMsg was transferred to PublishMsg during processing, which added unnecessary complexity and overhead. With this update, DevicePublishMsg is processed directly, streamlining the workflow.

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.

Front-End feature checklist

  • Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
  • If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.

Back-End feature checklist

  • Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
  • If new dependency was added: the dependency tree is checked for conflicts.

@ShvaykaD ShvaykaD added the Ignore for release Ignore this PR for release notes label Nov 11, 2024
@ShvaykaD ShvaykaD added this to the 2.0.1 milestone Nov 11, 2024
@dmytro-landiak dmytro-landiak merged commit 9d3de7e into main Nov 18, 2024
3 checks passed
@dmytro-landiak dmytro-landiak deleted the refactoring/device-publish-msg-handling branch November 18, 2024 13:49
@dmytro-landiak dmytro-landiak added Core Minor improvement to Core services and removed Ignore for release Ignore this PR for release notes labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Minor improvement to Core services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants