Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Redis cluster topology refresh options for Jedis implementation #184

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

ShvaykaD
Copy link
Contributor

@ShvaykaD ShvaykaD commented Nov 28, 2024

Pull Request description

Issue: #180

Note:
Currently, the project has separate configurations for both Lettuce and Jedis to support cluster topology refresh options. This is a temporary arrangement. In the future, we plan to standardize and use Lettuce exclusively across the entire project.

New configuration:

# Redis lettuce configuration parameters
lettuce:
  ...
  config:
    ...
    cluster:
      topology-refresh:
        # Enables or disables periodic cluster topology updates.
        # Useful for Redis Cluster setup to handle topology changes,
        # such as node failover, restarts, or IP address changes
        enabled: "${REDIS_LETTUCE_CLUSTER_TOPOLOGY_REFRESH_ENABLED:false}"
        # Specifies the interval (in seconds) for periodic cluster topology updates
        period: "${REDIS_LETTUCE_CLUSTER_TOPOLOGY_REFRESH_PERIOD_SEC:60}"

# Redis jedis configuration parameters
jedis:
  cluster:
    topology-refresh:
      # Enables or disables periodic cluster topology updates.
      # Useful for Redis cluster setup to handle topology changes,
      # such as node failover, restarts, or IP address changes
      enabled: "${REDIS_JEDIS_CLUSTER_TOPOLOGY_REFRESH_ENABLED:false}"
      # Specifies the interval (in seconds) for periodic cluster topology updates
      period: "${REDIS_JEDIS_CLUSTER_TOPOLOGY_REFRESH_PERIOD_SEC:60}"

Additional ctx:

Please note that the configuration structure might change following the PR review process. We recommend revisiting and reviewing the final configuration after the official release to ensure it aligns with the expected requirements.

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.

Front-End feature checklist

  • Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
  • If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.

Back-End feature checklist

  • Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
  • If new dependency was added: the dependency tree is checked for conflicts.

@ShvaykaD ShvaykaD added the Bug Something isn't working label Nov 28, 2024
@ShvaykaD ShvaykaD added this to the 2.0.1 milestone Nov 28, 2024
@dmytro-landiak dmytro-landiak merged commit 305ba25 into main Nov 28, 2024
3 checks passed
@dmytro-landiak dmytro-landiak deleted the bugfix/jedis-cluster-topology-refresh branch November 28, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants