Fixed TBClient reconnecting #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbeacon
requested changes
Mar 18, 2024
|
|
||
| connection_logger = getLogger('tb_connection') | ||
| new_tb_client = TBClient(config, old_tb_client.get_config_folder_path(), connection_logger) | ||
| while self._gateway.tb_client.client.is_connected(): |
There was a problem hiding this comment.
This loop can cause the gateway stuck, probably, it will be better to add check is the gateway stopped or no, to avoid hold before stop.
|
|
||
| connection_state = False | ||
| use_new_config = True | ||
| while not connection_state: |
There was a problem hiding this comment.
Please add check for gateway status - is it stopped or no.
| self._gateway.__subscribed_to_rpc_topics = False | ||
| new_tb_client = TBClient(config if use_new_config else old_tb_client_config, old_tb_client_config_path, connection_logger) | ||
| new_tb_client.connect() | ||
| while time() - apply_start <= 30 and not connection_state: |
There was a problem hiding this comment.
Check is gateway running will be nice here as well.
| else: | ||
| new_tb_client.disconnect() | ||
| new_tb_client.stop() | ||
| while new_tb_client.client.is_connected(): |
There was a problem hiding this comment.
Please add a check is gateway running or stopped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.