Proxy pattern smart wallet factory contracts #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attern-wallet-factory
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+17
to
+22
| function data() internal pure returns (Data storage baseAccountFactoryData) { | ||
| bytes32 position = BASE_ACCOUNT_FACTORY_STORAGE_POSITION; | ||
| assembly { | ||
| baseAccountFactoryData.slot := position | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Assembly usage Warning
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
| {} | ||
|
|
||
| /// @notice Initializes the factory contract. | ||
| function initialize(address _defaultAdmin, string memory _contractURI) external initializer { |
There was a problem hiding this comment.
niice we can pass contractURI now :D
| IEntryPoint _entrypoint, | ||
| Extension[] memory _defaultExtensions | ||
| ) | ||
| constructor(IEntryPoint _entrypoint, Extension[] memory _defaultExtensions) |
There was a problem hiding this comment.
also this means we can now use publish feature for dynamic contracts properly 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #561