Revert account factory proxy deploy back to direct deploy #578
+81
−268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given these benchmarks, we are reverting the account factories back from proxy deploys to direct deploys.
Presumably, app developers front costs of deploying a factory and onboarding users. All the savings from a proxy deployed factory are quickly offset upon onboarding a small amount of users, after which
createAccount
calls will permanently be more expensive compared to if the factory were direct deployed -- this is a bad trade-off.