Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert account factory proxy deploy back to direct deploy #578

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

nkrishang
Copy link
Contributor

Given these benchmarks, we are reverting the account factories back from proxy deploys to direct deploys.

Presumably, app developers front costs of deploying a factory and onboarding users. All the savings from a proxy deployed factory are quickly offset upon onboarding a small amount of users, after which createAccount calls will permanently be more expensive compared to if the factory were direct deployed -- this is a bad trade-off.

proxy-v-direct-deploy

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (85874e3) 63.07% compared to head (7d2f2c1) 62.94%.

Files Patch % Lines
...cts/prebuilts/account/utils/BaseAccountFactory.sol 80.00% 2 Missing ⚠️
...racts/prebuilts/account/managed/ManagedAccount.sol 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   63.07%   62.94%   -0.14%     
==========================================
  Files         216      215       -1     
  Lines        6657     6639      -18     
==========================================
- Hits         4199     4179      -20     
- Misses       2458     2460       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkrishang nkrishang merged commit 791e8df into main Nov 20, 2023
9 checks passed
@nkrishang nkrishang deleted the nkrishang/revert-sw-factory-proxy-deploy branch November 20, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant