Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve: Deletion on mapping containing a struct-with-mapping #602 #608

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

nkrishang
Copy link
Contributor

Resolves #602

Although the alert points out struct deletion correctly, the updated test_unpublish_state in ContractPublisher.t.sol shows that the struct deletion is handled correctly.

Particularly: n number of publishContract calls --> one unpublishContract call --> publishContract call again -- does not revive the previously unpublished versions of the contract.

@nkrishang nkrishang self-assigned this Jan 25, 2024
@nkrishang nkrishang enabled auto-merge (squash) January 25, 2024 09:45
@nkrishang nkrishang merged commit 4ff7235 into main Jan 25, 2024
7 checks passed
@nkrishang nkrishang deleted the nk/fix-slither-1-0-mapping-deletion branch January 25, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deletion on mapping containing a struct-with-mapping
1 participant