Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seaport bulk sig support for smart accounts: AccountSeaportBulkSigSupport #633

Merged
merged 8 commits into from
Mar 26, 2024

fix prettier error

03f77c1
Select commit
Loading
Failed to load commit list.
Merged

Seaport bulk sig support for smart accounts: AccountSeaportBulkSigSupport #633

fix prettier error
03f77c1
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither succeeded Mar 26, 2024 in 11s

11 new alerts including 1 medium severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

  • 1 medium

Other Alerts:

  • 10 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 364 in contracts/extension/SeaportOrderParser.sol

See this annotation in the file changed.

Check warning on line 521 in contracts/extension/SeaportOrderParser.sol

See this annotation in the file changed.

Code scanning / Slither

Assembly usage Warning

SeaportOrderParser._lookupBulkOrderTypehash.asm_0.ternary() uses assembly
- INLINE ASM

Check warning on line 516 in contracts/extension/SeaportOrderParser.sol

See this annotation in the file changed.

Code scanning / Slither

Assembly usage Warning

SeaportEIP1271._lookupBulkOrderTypehash.asm_0.lookupTypeHash() uses assembly
- INLINE ASM

Check warning on line 549 in contracts/extension/SeaportOrderParser.sol

See this annotation in the file changed.

Code scanning / Slither

Assembly usage Warning

SeaportOrderParser._deriveEIP712Digest(bytes32,bytes32) uses assembly
- INLINE ASM

Check warning on line 521 in contracts/extension/SeaportOrderParser.sol

See this annotation in the file changed.

Code scanning / Slither

Assembly usage Warning

SeaportEIP1271._lookupBulkOrderTypehash.asm_0.ternary() uses assembly
- INLINE ASM

Check warning on line 516 in contracts/extension/SeaportOrderParser.sol

See this annotation in the file changed.

Code scanning / Slither

Assembly usage Warning

AccountSeaportBulkSigSupport._lookupBulkOrderTypehash.asm_0.lookupTypeHash() uses assembly
- INLINE ASM

Check warning on line 526 in contracts/extension/SeaportOrderParser.sol

See this annotation in the file changed.

Code scanning / Slither

Assembly usage Warning

SeaportOrderParser._lookupBulkOrderTypehash(uint256) uses assembly
- INLINE ASM

Check warning on line 206 in contracts/extension/SeaportOrderParser.sol

See this annotation in the file changed.

Code scanning / Slither

Assembly usage Warning

SeaportOrderParser._deriveOrderHash(OrderParameters,uint256) uses assembly
- INLINE ASM
- INLINE ASM
- INLINE ASM

Check warning on line 357 in contracts/extension/SeaportOrderParser.sol

See this annotation in the file changed.

Code scanning / Slither

Assembly usage Warning

SeaportOrderParser._computeBulkOrderProof(bytes,bytes32) uses assembly
- INLINE ASM
- INLINE ASM

Check warning on line 516 in contracts/extension/SeaportOrderParser.sol

See this annotation in the file changed.

Code scanning / Slither

Cyclomatic complexity Warning

SeaportEIP1271._lookupBulkOrderTypehash.asm_0.lookupTypeHash() has a high cyclomatic complexity (12).

Check warning on line 516 in contracts/extension/SeaportOrderParser.sol

See this annotation in the file changed.

Code scanning / Slither

Cyclomatic complexity Warning

SeaportOrderParser._lookupBulkOrderTypehash.asm_0.lookupTypeHash() has a high cyclomatic complexity (12).