-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@thirdweb-dev/sdk incompatibility issue with ethers v6 #2057
Comments
+1 Is this on the roadmap? |
@sebpalluel @bennettl thank you for submitting the issue - we're actively working on an upgrade that will allow to use the SDK alongside ethers v6, v5 and viem. Will update here with progress updates - cc @jnsdls |
I have the same issues in here, hope this will be updated ASAP |
Any update on timing? |
We're close to opening up the alpha version of our new SDK which will be compatible with ethers 5, 6 and viem. Here's the alpha tester sign up link if you're interested: https://docs.google.com/forms/d/e/1FAIpQLSfMTy_1ZKPHAGIs8hQAlLfR_Xur1tw5soF_fEumFawdBEhK5g/viewform?usp=send_form Adding @saminacodes and @jnsdls for 👀 |
Our lead dev Sameer will be filling this out. Thank you! |
@joaquim-verges -- we need Ether 6 compatibility for the SDK, and have filled up the form to get access to the alpha version. Could you please give us access? Thanks! |
Hey Acme! Here are some links to get you started: Let us know if you have any questions and please join our #sdk-v5-alpha Discord channel to directly speak with the engineers on the project. :D |
Needed |
Please give us an update. I'm about to have torecode half of my marketplace that connects to seaport js at this point. We filled out the form and got nothing in return. At this point its delaying our launch... PLEASE HELP! |
Do we have a date when this will be released? We desperately requires Ethers v6 support |
hey @hexforcesy @GENERATIONART we have an Note that this will only work with the new version of the SDK (currently in alpha, the APIs are about to be stable today or tomorrow and we'll go to beta) |
also cc @AcmeNiles @bennettl @juniardys ☝️ |
ETA on beta? |
@hexforcesy beta is out today! https://blog.thirdweb.com/changelog/introducing-the-unified-thirdweb-sdk/ |
posting the ethers6 adapter docs here for anyone looking for it: https://portal.thirdweb.com/typescript/v5/adapters#ethers-v6 |
the new SDK |
Thank you
We will deploy this today.
Regards
…________________________________
From: Jonas Daniels ***@***.***>
Sent: 29 March 2024 11:54
To: thirdweb-dev/js ***@***.***>
Cc: SY ***@***.***>; Mention ***@***.***>
Subject: Re: [thirdweb-dev/js] @thirdweb-dev/sdk incompatibility issue with ethers v6 (Issue #2057)
the new SDK npm i thirdweb is now stable as v5 it is fully compatible with ethers v5, ethers v6 and viem (including adapters for each)
—
Reply to this email directly, view it on GitHub<#2057 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQKD7FOQH765PEIJZSYEI6LY2VI73AVCNFSM6AAAAABALIHRNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXGE2TAMZWHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I'm encountering an issue related to
ethers v6
with@thirdweb-dev/sdk
.The specific error is:
Cannot find module 'ethers/lib/utils' from '../../../node_modules/.pnpm/@thirdweb-dev+sdk@4.0.19_ethers@6.9.0_typescript@5.3.2/node_modules/@thirdweb-dev/sdk/dist/index-0cf99325.cjs.dev.js'
.This appears to stem from a change in the file path structure in
ethers v6
(refer to this issue for more details).To work around this, I've temporarily resorted to creating an alias for ethers as
"ethers6": "npm:ethers@^6.9.0"
, allowing us to use it throughout the project viaimport { ethers } from 'ethers6';
, while also maintainingethers v5.7.2
.However, this solution is quite hacky and not ideal. It would be greatly beneficial for
@thirdweb-dev/sdk
to extend support toethers v6
, especially considering it has reached a stable release. Currently,@thirdweb-dev/sdk
is the sole dependency in our stack that is causing compatibility issues withethers v6
.The text was updated successfully, but these errors were encountered: