Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@thirdweb-dev/sdk incompatibility issue with ethers v6 #2057

Closed
sebpalluel opened this issue Dec 7, 2023 · 18 comments
Closed

@thirdweb-dev/sdk incompatibility issue with ethers v6 #2057

sebpalluel opened this issue Dec 7, 2023 · 18 comments
Assignees
Labels
Planned Requests that will be worked on at some point in the future.

Comments

@sebpalluel
Copy link

I'm encountering an issue related to ethers v6 with @thirdweb-dev/sdk.

The specific error is:
Cannot find module 'ethers/lib/utils' from '../../../node_modules/.pnpm/@thirdweb-dev+sdk@4.0.19_ethers@6.9.0_typescript@5.3.2/node_modules/@thirdweb-dev/sdk/dist/index-0cf99325.cjs.dev.js'.
This appears to stem from a change in the file path structure in ethers v6 (refer to this issue for more details).

To work around this, I've temporarily resorted to creating an alias for ethers as "ethers6": "npm:ethers@^6.9.0", allowing us to use it throughout the project via import { ethers } from 'ethers6';, while also maintaining ethers v5.7.2.

However, this solution is quite hacky and not ideal. It would be greatly beneficial for @thirdweb-dev/sdk to extend support to ethers v6, especially considering it has reached a stable release. Currently, @thirdweb-dev/sdk is the sole dependency in our stack that is causing compatibility issues with ethers v6.

@bennettl
Copy link

+1 Is this on the roadmap?

@joaquim-verges
Copy link
Member

@sebpalluel @bennettl thank you for submitting the issue - we're actively working on an upgrade that will allow to use the SDK alongside ethers v6, v5 and viem.

Will update here with progress updates - cc @jnsdls

@jnsdls jnsdls self-assigned this Dec 14, 2023
@jnsdls jnsdls added the Planned Requests that will be worked on at some point in the future. label Dec 14, 2023
@juniardys
Copy link

I have the same issues in here, hope this will be updated ASAP

@GENERATIONART
Copy link

Any update on timing?

@joaquim-verges
Copy link
Member

We're close to opening up the alpha version of our new SDK which will be compatible with ethers 5, 6 and viem.

Here's the alpha tester sign up link if you're interested: https://docs.google.com/forms/d/e/1FAIpQLSfMTy_1ZKPHAGIs8hQAlLfR_Xur1tw5soF_fEumFawdBEhK5g/viewform?usp=send_form

Adding @saminacodes and @jnsdls for 👀

@GENERATIONART
Copy link

Our lead dev Sameer will be filling this out. Thank you!

@AcmeNiles
Copy link

@joaquim-verges -- we need Ether 6 compatibility for the SDK, and have filled up the form to get access to the alpha version. Could you please give us access? Thanks!

@saminacodes
Copy link
Member

Hey Acme!

Here are some links to get you started:

Let us know if you have any questions and please join our #sdk-v5-alpha Discord channel to directly speak with the engineers on the project. :D

@GrieverSY
Copy link

@joaquim-verges -- we need Ether 6 compatibility for the SDK, and have filled up the form to get access to the alpha version. Could you please give us access? Thanks!

Needed

@GENERATIONART
Copy link

Please give us an update. I'm about to have torecode half of my marketplace that connects to seaport js at this point. We filled out the form and got nothing in return. At this point its delaying our launch... PLEASE HELP!

@GrieverSY
Copy link

Do we have a date when this will be released? We desperately requires Ethers v6 support

@jnsdls
Copy link
Member

jnsdls commented Feb 20, 2024

hey @hexforcesy @GENERATIONART we have an ethers6adapter in the new version of our SDK that would be the path forward here:

New Docs
Ethers6Adapter

Note that this will only work with the new version of the SDK (currently in alpha, the APIs are about to be stable today or tomorrow and we'll go to beta)

@jnsdls
Copy link
Member

jnsdls commented Feb 20, 2024

also cc @AcmeNiles @bennettl @juniardys ☝️

@GrieverSY
Copy link

ETA on beta?

@joaquim-verges
Copy link
Member

@hexforcesy beta is out today! https://blog.thirdweb.com/changelog/introducing-the-unified-thirdweb-sdk/

@joaquim-verges
Copy link
Member

posting the ethers6 adapter docs here for anyone looking for it: https://portal.thirdweb.com/typescript/v5/adapters#ethers-v6

@jnsdls
Copy link
Member

jnsdls commented Mar 29, 2024

the new SDK npm i thirdweb is now stable as v5 it is fully compatible with ethers v5, ethers v6 and viem (including adapters for each)

@jnsdls jnsdls closed this as completed Mar 29, 2024
@GrieverSY
Copy link

GrieverSY commented Apr 1, 2024 via email

jnsdls pushed a commit that referenced this issue Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Planned Requests that will be worked on at some point in the future.
Projects
None yet
Development

No branches or pull requests

9 participants