feat: Connect components in React Native [part 1] #3246

joaquim-verges · 2024-06-08T02:53:12Z

PR-Codex overview

This PR focuses on restructuring file paths, updating imports, adding new design system configurations, and improving wallet functionalities.

Detailed summary

Restructured file paths and updated imports
Added new design system configurations for spacing, radius, and font size
Updated wallet functionalities for sending tokens
Improved wallet connection and authentication processes

The following files were skipped due to too many changes: packages/thirdweb/src/react/web/wallets/shared/OTPLoginUI.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/WalletSelector.tsx, packages/thirdweb/src/react/web/wallets/shared/SocialLogin.tsx, packages/thirdweb/src/react/native/ui/components/TokenIcon.tsx, packages/thirdweb/src/react/web/wallets/shared/PassKeyLogin.tsx, packages/thirdweb/src/react/web/ui/PayEmbed.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/fiat/FiatSteps.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/SmartWalletConnectUI.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/TokenSelector.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/ViewFunds.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/SignatureScreen.tsx, packages/thirdweb/src/react/web/ui/components/WalletImage.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/AnyWalletConnectUI.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/swap/PayWithCrypto.tsx, packages/thirdweb/src/react/native/ui/connect/ErrorView.tsx, packages/thirdweb/src/react/web/hooks/transaction/useSendTransaction.tsx, packages/thirdweb/src/react/native/ui/connect/SuccessView.tsx, packages/react-native-adapter/README.md, packages/thirdweb/src/react/native/ui/components/text.tsx, packages/thirdweb/src/react/native/ui/components/ChainIcon.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/ConnectButton.tsx, packages/thirdweb/src/wallets/manager/index.ts, packages/thirdweb/src/react/web/wallets/shared/ConnectWalletSocialOptions.tsx, packages/thirdweb/src/react/native/ui/components/Address.tsx, packages/thirdweb/src/react/web/hooks/wallets/useAutoConnect.ts, packages/thirdweb/src/react/native/ui/components/RNImage.tsx, packages/thirdweb/src/exports/react.native.ts, packages/thirdweb/src/react/web/ui/ConnectWallet/ConnectButtonProps.ts, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx, packages/thirdweb/src/react/native/ui/components/Header.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/defaultTokens.ts, packages/thirdweb/src/react/native/ui/connect/ReceiveScreen.tsx, packages/thirdweb/src/react/native/ui/components/button.tsx, packages/thirdweb/src/exports/react.ts, packages/thirdweb/src/react/native/ui/components/WalletImage.tsx, packages/thirdweb/src/react/native/ui/connect/ConnectedButton.tsx, packages/thirdweb/src/react/core/hooks/wallets/useSendToken.ts, packages/thirdweb/src/react/web/ui/ConnectWallet/screens/SendFunds.tsx, packages/thirdweb/src/react/native/ui/components/input.tsx, packages/thirdweb/src/react/core/utils/wallet.ts, packages/thirdweb/src/react/web/ui/components/ChainIcon.tsx, packages/thirdweb/src/react/native/ui/connect/ExternalWalletsList.tsx, packages/thirdweb/package.json, packages/thirdweb/src/react/native/ui/connect/TokenListScreen.tsx, packages/thirdweb/src/react/native/ui/connect/ConnectButton.tsx, packages/thirdweb/src/react/native/ui/connect/SendScreen.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Details.tsx, packages/thirdweb/src/react/native/ui/connect/ConnectModal.tsx, packages/thirdweb/src/react/native/ui/connect/InAppWalletUI.tsx, packages/thirdweb/src/react/core/hooks/connection/ConnectEmbedProps.ts, packages/thirdweb/src/react/native/ui/connect/ConnectedModal.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectEmbed.tsx, packages/thirdweb/src/react/web/ui/ConnectWallet/icons/dataUris.ts, packages/thirdweb/src/react/native/ui/icons/svgs.ts, pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-06-08T02:53:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 2, 2024 2:17am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 2, 2024 2:17am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 2, 2024 2:17am

changeset-bot · 2024-06-08T02:53:16Z

⚠️ No Changeset found

Latest commit: 0077d38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

joaquim-verges · 2024-06-08T02:53:25Z

feat: Connect components in React Native [part 2] #3438
feat: Connect components in React Native [part 1] #3246 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite

codspeed-hq · 2024-06-08T02:55:42Z

CodSpeed Performance Report

Merging #3246 will improve performances by 16.44%

_{Comparing joaquim/rn-ui-connect (0077d38) with main (53aa867)}

Summary

⚡ 1 improvements
✅ 8 untouched benchmarks

Benchmarks breakdown

	Benchmark	`main`	`joaquim/rn-ui-connect`	Change
⚡	`keccakId`	1.5 ms	1.3 ms	+16.44%

github-actions · 2024-06-08T02:56:43Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	40.48 KB (+0.04% 🔺)	810 ms (+0.04% 🔺)	2.7 s (-62.44% 🔽)	3.5 s
thirdweb (cjs)	90.48 KB (+0.55% 🔺)	1.9 s (+0.55% 🔺)	6.1 s (-28.08% 🔽)	7.9 s
thirdweb (minimal + tree-shaking)	4.79 KB (0%)	96 ms (0%)	128 ms (-76.96% 🔽)	224 ms
thirdweb/chains (tree-shaking)	423 B (0%)	10 ms (0%)	298 ms (+199% 🔺)	308 ms
thirdweb/react (minimal + tree-shaking)	13.52 KB (+0.03% 🔺)	271 ms (+0.03% 🔺)	349 ms (-53.31% 🔽)	620 ms

codecov · 2024-06-08T08:19:26Z

Codecov Report

Attention: Patch coverage is 52.18579% with 175 lines in your changes missing coverage. Please review.

Project coverage is 62.76%. Comparing base (53aa867) to head (0077d38).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3246      +/-   ##
==========================================
+ Coverage   62.74%   62.76%   +0.02%     
==========================================
  Files         898      897       -1     
  Lines       68677    68737      +60     
  Branches     3671     3684      +13     
==========================================
+ Hits        43091    43145      +54     
- Misses      24898    24904       +6     
  Partials      688      688

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.59% <ø> (ø)`		Carriedforward from 53aa867
packages	`62.23% <52.18%> (+0.02%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
...react/core/hooks/transaction/useSendTransaction.ts	`46.81% <100.00%> (ø)`
...web/src/react/core/hooks/wallets/useAutoConnect.ts	`61.20% <100.00%> (ø)`
...ges/thirdweb/src/react/core/utils/defaultTokens.ts	`100.00% <100.00%> (ø)`
...ges/thirdweb/src/react/core/utils/isSmartWallet.ts	`90.00% <ø> (ø)`
...kages/thirdweb/src/react/core/utils/socialIcons.ts	`100.00% <100.00%> (ø)`
packages/thirdweb/src/react/core/utils/storage.ts	`35.29% <100.00%> (ø)`
...react/web/hooks/transaction/useSendTransaction.tsx	`32.03% <100.00%> (ø)`
...b/src/react/web/ui/ConnectWallet/ConnectButton.tsx	`56.54% <100.00%> (ø)`
.../web/ui/ConnectWallet/Modal/AnyWalletConnectUI.tsx	`14.96% <100.00%> (ø)`
...eb/ui/ConnectWallet/Modal/SmartWalletConnectUI.tsx	`10.64% <100.00%> (ø)`
... and 28 more

... and 6 files with indirect coverage changes

socket-security · 2024-07-01T20:14:16Z

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

packages/thirdweb/package.json

packages/thirdweb/src/react/native/ui/connect/ConnectedModal.tsx

packages/thirdweb/src/react/native/ui/connect/ExternalWalletsList.tsx

jnsdls · 2024-07-01T23:04:58Z

packages/thirdweb/src/react/native/ui/connect/InAppWalletUI.tsx

+  props: InAppWalletFormUIProps & { auth: InAppWalletSocialAuth },
+) {
+  const { theme, wallet, auth, client, connectMutation } = props;
+  // TODO (rn) - move this onPress and state up


graphite-app · 2024-07-02T01:59:54Z

Merge activity

Jul 1, 9:59 PM EDT: joaquim-verges added this pull request to the Graphite merge queue.
Jul 1, 10:17 PM EDT: joaquim-verges merged this pull request with the Graphite merge queue.

## PR-Codex overview This PR focuses on refactoring, updating dependencies, and improving code organization. ### Detailed summary - Updated dependencies and file paths - Refactored wallet-related functions - Added default wallets for various chains - Updated UI components and design system configurations > The following files were skipped due to too many changes: `packages/thirdweb/src/react/web/wallets/shared/OTPLoginUI.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/WalletSelector.tsx`, `packages/thirdweb/src/react/web/wallets/shared/SocialLogin.tsx`, `packages/thirdweb/src/react/native/ui/components/TokenIcon.tsx`, `packages/thirdweb/src/react/web/wallets/shared/PassKeyLogin.tsx`, `packages/thirdweb/src/react/web/ui/PayEmbed.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/fiat/FiatSteps.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/SmartWalletConnectUI.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/screens/TokenSelector.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/screens/ViewFunds.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/screens/SignatureScreen.tsx`, `packages/thirdweb/src/react/web/ui/components/WalletImage.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/AnyWalletConnectUI.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/swap/PayWithCrypto.tsx`, `packages/thirdweb/src/react/native/ui/connect/ErrorView.tsx`, `packages/thirdweb/src/react/web/hooks/transaction/useSendTransaction.tsx`, `packages/thirdweb/src/react/native/ui/connect/SuccessView.tsx`, `packages/react-native-adapter/README.md`, `packages/thirdweb/src/react/native/ui/components/text.tsx`, `packages/thirdweb/src/react/native/ui/components/ChainIcon.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/ConnectButton.tsx`, `packages/thirdweb/src/wallets/manager/index.ts`, `packages/thirdweb/src/react/web/wallets/shared/ConnectWalletSocialOptions.tsx`, `packages/thirdweb/src/react/native/ui/components/Address.tsx`, `packages/thirdweb/src/react/web/hooks/wallets/useAutoConnect.ts`, `packages/thirdweb/src/react/native/ui/components/RNImage.tsx`, `packages/thirdweb/src/exports/react.native.ts`, `packages/thirdweb/src/react/web/ui/ConnectWallet/ConnectButtonProps.ts`, `packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx`, `packages/thirdweb/src/react/native/ui/components/Header.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/defaultTokens.ts`, `packages/thirdweb/src/react/native/ui/connect/ReceiveScreen.tsx`, `packages/thirdweb/src/react/native/ui/components/button.tsx`, `packages/thirdweb/src/exports/react.ts`, `packages/thirdweb/src/react/native/ui/components/WalletImage.tsx`, `packages/thirdweb/src/react/native/ui/connect/ConnectedButton.tsx`, `packages/thirdweb/src/react/core/hooks/wallets/useSendToken.ts`, `packages/thirdweb/src/react/web/ui/ConnectWallet/screens/SendFunds.tsx`, `packages/thirdweb/src/react/native/ui/components/input.tsx`, `packages/thirdweb/src/react/core/utils/wallet.ts`, `packages/thirdweb/src/react/web/ui/components/ChainIcon.tsx`, `packages/thirdweb/src/react/native/ui/connect/ExternalWalletsList.tsx`, `packages/thirdweb/package.json`, `packages/thirdweb/src/react/native/ui/connect/TokenListScreen.tsx`, `packages/thirdweb/src/react/native/ui/connect/ConnectButton.tsx`, `packages/thirdweb/src/react/native/ui/connect/SendScreen.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/Details.tsx`, `packages/thirdweb/src/react/native/ui/connect/ConnectModal.tsx`, `packages/thirdweb/src/react/native/ui/connect/InAppWalletUI.tsx`, `packages/thirdweb/src/react/core/hooks/connection/ConnectEmbedProps.ts`, `packages/thirdweb/src/react/native/ui/connect/ConnectedModal.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/Modal/ConnectEmbed.tsx`, `packages/thirdweb/src/react/web/ui/ConnectWallet/icons/dataUris.ts`, `packages/thirdweb/src/react/native/ui/icons/svgs.ts`, `pnpm-lock.yaml` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

joaquim-verges changed the title ~~WIP connect button~~ [WIP] connect button for react native Jun 8, 2024

joaquim-verges requested review from gregfromstl, jnsdls and MananTank June 8, 2024 02:54

joaquim-verges marked this pull request as ready for review June 8, 2024 02:54

vercel bot deployed to Preview June 8, 2024 08:17 View deployment

vercel bot had a problem deploying to Preview June 8, 2024 09:32 Failure

vercel bot deployed to Preview June 8, 2024 09:56 View deployment

vercel bot deployed to Preview June 9, 2024 03:41 View deployment

vercel bot had a problem deploying to Preview June 9, 2024 10:39 Failure

vercel bot had a problem deploying to Preview June 9, 2024 22:22 Failure

vercel bot had a problem deploying to Preview June 9, 2024 22:31 Failure

vercel bot deployed to Preview June 9, 2024 22:40 View deployment

vercel bot deployed to Preview June 9, 2024 23:12 View deployment

vercel bot deployed to Preview June 9, 2024 23:18 View deployment

vercel bot deployed to Preview June 10, 2024 01:13 View deployment

vercel bot deployed to Preview June 10, 2024 02:54 View deployment

vercel bot deployed to Preview June 10, 2024 08:41 View deployment

vercel bot deployed to Preview June 10, 2024 09:15 View deployment

joaquim-verges mentioned this pull request Jun 15, 2024

[React Native] [Thirdweb V4] : JSON value '<null>' of type NSNull cannot be converted to NSString warning #3283

Open

vercel bot deployed to Preview June 17, 2024 04:02 View deployment

vercel bot deployed to Preview June 17, 2024 08:02 View deployment

joaquim-verges force-pushed the joaquim/rn-ui-connect branch from 1f6b5f0 to 97432d7 Compare June 17, 2024 19:06

vercel bot had a problem deploying to Preview June 17, 2024 19:21 Failure

vercel bot deployed to Preview – thirdweb_playground July 1, 2024 19:45 View deployment

vercel bot deployed to Preview – thirdweb-www July 1, 2024 19:56 View deployment

vercel bot deployed to Preview – wallet-ui July 1, 2024 20:16 View deployment

vercel bot deployed to Preview – thirdweb_playground July 1, 2024 20:16 View deployment

vercel bot had a problem deploying to Preview – thirdweb-www July 1, 2024 20:24 Failure

joaquim-verges force-pushed the joaquim/rn-ui-connect branch from 3590a41 to 6cd4865 Compare July 1, 2024 22:37

vercel bot deployed to Preview – wallet-ui July 1, 2024 22:41 View deployment

vercel bot deployed to Preview – thirdweb_playground July 1, 2024 22:41 View deployment

vercel bot had a problem deploying to Preview – thirdweb-www July 1, 2024 22:48 Failure

jnsdls requested changes Jul 1, 2024

View reviewed changes

vercel bot had a problem deploying to Preview – thirdweb_playground July 2, 2024 00:51 Failure

jnsdls approved these changes Jul 2, 2024

View reviewed changes

vercel bot had a problem deploying to Preview – wallet-ui July 2, 2024 00:52 Failure

vercel bot had a problem deploying to Preview – thirdweb-www July 2, 2024 00:53 Failure

joaquim-verges force-pushed the joaquim/rn-ui-connect branch from f810865 to 575bf50 Compare July 2, 2024 00:58

vercel bot deployed to Preview – thirdweb_playground July 2, 2024 01:09 View deployment

vercel bot deployed to Preview – wallet-ui July 2, 2024 01:09 View deployment

vercel bot deployed to Preview – thirdweb-www July 2, 2024 01:18 View deployment

joaquim-verges force-pushed the joaquim/rn-ui-connect branch from 575bf50 to 0077d38 Compare July 2, 2024 02:01

vercel bot deployed to Preview – thirdweb_playground July 2, 2024 02:05 View deployment

vercel bot deployed to Preview – wallet-ui July 2, 2024 02:05 View deployment

vercel bot deployed to Preview – thirdweb-www July 2, 2024 02:17 View deployment

graphite-app bot merged commit 0077d38 into main Jul 2, 2024
30 of 32 checks passed

graphite-app bot deleted the joaquim/rn-ui-connect branch July 2, 2024 02:17

vercel bot deployed to Production – thirdweb_playground July 2, 2024 02:20 View deployment

vercel bot deployed to Production – wallet-ui July 2, 2024 02:20 View deployment

vercel bot deployed to Production – thirdweb-www July 2, 2024 02:29 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Connect components in React Native [part 1] #3246

feat: Connect components in React Native [part 1] #3246

joaquim-verges commented Jun 8, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Jun 8, 2024 •

edited

Loading

changeset-bot bot commented Jun 8, 2024 •

edited

Loading

joaquim-verges commented Jun 8, 2024 •

edited

Loading

codspeed-hq bot commented Jun 8, 2024 •

edited

Loading

github-actions bot commented Jun 8, 2024 •

edited

Loading

codecov bot commented Jun 8, 2024 •

edited

Loading

socket-security bot commented Jul 1, 2024 •

edited

Loading

jnsdls Jul 1, 2024

graphite-app bot commented Jul 2, 2024 •

edited

Loading

feat: Connect components in React Native [part 1] #3246

feat: Connect components in React Native [part 1] #3246

Conversation

joaquim-verges commented Jun 8, 2024 • edited by pr-codex bot Loading

PR-Codex overview

Detailed summary

vercel bot commented Jun 8, 2024 • edited Loading

changeset-bot bot commented Jun 8, 2024 • edited Loading

⚠️ No Changeset found

joaquim-verges commented Jun 8, 2024 • edited Loading

codspeed-hq bot commented Jun 8, 2024 • edited Loading

CodSpeed Performance Report

Merging #3246 will improve performances by 16.44%

Summary

Benchmarks breakdown

github-actions bot commented Jun 8, 2024 • edited Loading

size-limit report 📦

codecov bot commented Jun 8, 2024 • edited Loading

Codecov Report

socket-security bot commented Jul 1, 2024 • edited Loading

jnsdls Jul 1, 2024

Choose a reason for hiding this comment

graphite-app bot commented Jul 2, 2024 • edited Loading

Merge activity

joaquim-verges commented Jun 8, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Jun 8, 2024 •

edited

Loading

changeset-bot bot commented Jun 8, 2024 •

edited

Loading

joaquim-verges commented Jun 8, 2024 •

edited

Loading

codspeed-hq bot commented Jun 8, 2024 •

edited

Loading

github-actions bot commented Jun 8, 2024 •

edited

Loading

codecov bot commented Jun 8, 2024 •

edited

Loading

socket-security bot commented Jul 1, 2024 •

edited

Loading

graphite-app bot commented Jul 2, 2024 •

edited

Loading