Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Billing page in team settings (chakra) #4457

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Sep 7, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

The focus of this PR is to refactor the billing settings page structure and logic.

Detailed summary

  • Refactored billing settings page structure and logic
  • Updated import paths for Billing components
  • Reorganized layout and page components for better organization

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 10:07pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 7, 2024 10:07pm
thirdweb_playground ⬜️ Skipped (Inspect) Sep 7, 2024 10:07pm
wallet-ui ⬜️ Skipped (Inspect) Sep 7, 2024 10:07pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 September 7, 2024 17:51 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 7, 2024 17:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 7, 2024 17:51 Inactive
Copy link

changeset-bot bot commented Sep 7, 2024

⚠️ No Changeset found

Latest commit: 1fbc1df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Sep 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 7, 2024
@MananTank MananTank marked this pull request as ready for review September 7, 2024 17:52
Copy link
Member Author

MananTank commented Sep 7, 2024

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.76%. Comparing base (aae9040) to head (1fbc1df).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4457   +/-   ##
=======================================
  Coverage   47.76%   47.76%           
=======================================
  Files        1014     1014           
  Lines       53277    53277           
  Branches     3701     3701           
=======================================
  Hits        25446    25446           
  Misses      27147    27147           
  Partials      684      684           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from aae9040
packages 43.16% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Sep 7, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.3 KB (0%) 866 ms (0%) 938 ms (+33.91% 🔺) 1.9 s
thirdweb (cjs) 100.41 KB (0%) 2.1 s (0%) 1.4 s (-5.03% 🔽) 3.4 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 102 ms (+1.92% 🔺) 198 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 94 ms (+821.19% 🔺) 104 ms
thirdweb/react (minimal + tree-shaking) 16.67 KB (0%) 334 ms (0%) 111 ms (-33.29% 🔽) 444 ms

@MananTank MananTank changed the title Add Billing in team settings (chakra) Add Billing page in team settings (chakra) Sep 7, 2024
);
}

return <Billing account={account} />;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for now but we have to desperately refactor this page it is causing massive problems already

Copy link

graphite-app bot commented Sep 7, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR refactors the billing settings pages by introducing a new `SettingsBillingPage` component and updating related components for better organization and structure.

### Detailed summary
- Introduces a new `SettingsBillingPage` component for billing settings
- Updates components to use the new `SettingsBillingPage`
- Removes unnecessary code related to account and router handling

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 09-07-wip_-_add_engine_pages_to_teams branch from 738dc5b to aae9040 Compare September 7, 2024 21:55
@MananTank MananTank force-pushed the 09-07-add_billing_in_team_settings_chakra_ branch from b447dcb to 1fbc1df Compare September 7, 2024 21:56
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 7, 2024 21:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 7, 2024 21:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 7, 2024 21:56 Inactive
Base automatically changed from 09-07-wip_-_add_engine_pages_to_teams to main September 7, 2024 22:08
@graphite-app graphite-app bot merged commit 1fbc1df into main Sep 7, 2024
30 checks passed
@graphite-app graphite-app bot deleted the 09-07-add_billing_in_team_settings_chakra_ branch September 7, 2024 22:08
@vercel vercel bot temporarily deployed to Production – docs-v2 September 7, 2024 22:08 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui September 7, 2024 22:08 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 7, 2024 22:08 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www September 7, 2024 22:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants