Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): update in-app wallet auth options and components #4757

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Sep 23, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

The focus of this PR is to update the in-app wallet functionality in the Playground web app.

Detailed summary

  • Added wallet configuration options to SponsoredInAppTxPreview component
  • Updated InAppConnectEmbed component with new wallet configuration
  • Refactored InAppConnectButton to InAppConnectEmbed and updated wallet configuration

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 8:39am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 23, 2024 8:39am
thirdweb-www ⬜️ Skipped (Inspect) Sep 23, 2024 8:39am
wallet-ui ⬜️ Skipped (Inspect) Sep 23, 2024 8:39am

@vercel vercel bot temporarily deployed to Preview – docs-v2 September 23, 2024 08:36 Inactive
Copy link

changeset-bot bot commented Sep 23, 2024

⚠️ No Changeset found

Latest commit: 6fa34d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb-www September 23, 2024 08:36 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 23, 2024 08:36 Inactive
Copy link

graphite-app bot commented Sep 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review September 23, 2024 08:36
@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Sep 23, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.04%. Comparing base (294ec4d) to head (6fa34d9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4757   +/-   ##
=======================================
  Coverage   49.04%   49.04%           
=======================================
  Files        1055     1055           
  Lines       56888    56888           
  Branches     3891     3891           
=======================================
  Hits        27903    27903           
  Misses      28352    28352           
  Partials      633      633           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 294ec4d
packages 45.11% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.89 KB (0%) 838 ms (0%) 585 ms (-15.71% 🔽) 1.5 s
thirdweb (cjs) 101.38 KB (0%) 2.1 s (0%) 1.6 s (+18.05% 🔺) 3.6 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 58 ms (+3.04% 🔺) 155 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 197 ms (+441.55% 🔺) 207 ms
thirdweb/react (minimal + tree-shaking) 16.73 KB (-0.01% 🔽) 335 ms (-0.01% 🔽) 204 ms (-5.66% 🔽) 539 ms

@joaquim-verges joaquim-verges merged commit b85fe2a into main Sep 23, 2024
31 checks passed
@joaquim-verges joaquim-verges deleted the feat_playground_update_in-app_wallet_auth_options_and_components branch September 23, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Playground Changes involving the Playground codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant