Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "push" script and task #4762

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Sep 23, 2024

PR-Codex overview

This PR focuses on modifying the turbo.json and package.json configuration files by removing the push configuration from turbo.json and updating the package.json scripts related to nightly releases.

Detailed summary

  • Removed the push configuration from turbo.json, including its cache option and dependsOn array.
  • Updated the package.json by removing the push script that triggered turbo run push --filter=./packages/*.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 7:46pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 7:46pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 7:46pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 7:46pm

Copy link

changeset-bot bot commented Sep 23, 2024

⚠️ No Changeset found

Latest commit: 3b91dad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Sep 23, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@jnsdls jnsdls marked this pull request as ready for review September 23, 2024 18:10
Copy link
Member Author

jnsdls commented Sep 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.06%. Comparing base (daf5fda) to head (3b91dad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4762   +/-   ##
=======================================
  Coverage   49.06%   49.06%           
=======================================
  Files        1054     1054           
  Lines       56865    56865           
  Branches     3888     3888           
=======================================
  Hits        27902    27902           
  Misses      28330    28330           
  Partials      633      633           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from daf5fda
packages 45.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Sep 23, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.91 KB (0%) 839 ms (0%) 365 ms (-14.93% 🔽) 1.3 s
thirdweb (cjs) 101.47 KB (0%) 2.1 s (0%) 1.1 s (+19.46% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 66 ms (-28.03% 🔽) 162 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 7 ms (-16.54% 🔽) 17 ms
thirdweb/react (minimal + tree-shaking) 16.73 KB (0%) 335 ms (0%) 199 ms (+73.61% 🔺) 534 ms

Copy link

graphite-app bot commented Sep 23, 2024

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on modifying the `turbo.json` and `package.json` configuration files, specifically removing certain caching options and adjusting command scripts related to the build process.

### Detailed summary
- In `turbo.json`, removed the `push` configuration and its `cache` and `dependsOn` settings.
- In `package.json`, removed the `push` script that executed `turbo run push --filter=./packages/*`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants