[React] Fix: Balance label space #4778
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 7629c44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
gregfromstl
force-pushed
the
fix/balance-label-space
branch
from
4eb3d4a
to
2300447
Compare
gregfromstl
requested review from
joaquim-verges,
MananTank,
jnsdls and
edwardysun
as code owners
gregfromstl
force-pushed
the
fix/balance-label-space
branch
from
2300447
to
cc75db6
Compare
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4778 +/- ##
==========================================
- Coverage 49.07% 49.06% -0.01%
==========================================
Files 1054 1054
Lines 56855 56866 +11
Branches 3889 3889
==========================================
Hits 27902 27902
- Misses 28320 28331 +11
Partials 633 633
*This pull request uses carry forward flags. Click here to find out more.
|
| "rules": { | ||
| "nursery": { | ||
| "noProcessEnv": "warn", | ||
| "useConsistentCurlyBraces": "off" |
| {formatBalanceOnButton(Number(balanceQuery.data.displayValue))}{" "} | ||
| {balanceQuery.data.symbol} |
There was a problem hiding this comment.
use string concat instead
| {formatBalanceOnButton(Number(balanceQuery.data.displayValue))}{" "} | |
| {balanceQuery.data.symbol} | |
| {`${formatBalanceOnButton(Number(balanceQuery.data.displayValue))} ${balanceQuery.data.symbol}`} |
| @@ -366,7 +366,7 @@ function DetailsModal(props: { | |||
| formatNumber(Number(balanceQuery.data.displayValue), 5) | |||
| ) : ( | |||
| <Skeleton height="1em" width="100px" /> | |||
| )} | |||
| )}{" "} | |||
There was a problem hiding this comment.
u can string concat the value + symbol and show the skeleton for both (probably better anyways)
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on improving the user interface of the connect wallet feature by fixing spacing issues in the native balance label and updating the
biome.jsonconfiguration to include a new linter rule.Detailed summary
packages/thirdweb/src/react/web/ui/ConnectWallet/Details.tsx.biome.jsonto adduseConsistentCurlyBraces: "off"under thenurserylinter rules.