Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize passkey authentication for iOS 15 #5214

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 29, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on optimizing the asynchronous calls involved in requesting WebAuthn credentials for iOS 15 by reducing the number of requests made to the server.

Detailed summary

  • Combined two asynchronous calls into a single Promise.all to fetch the challenge data and retrieve the credentialId.
  • Removed redundant fetching of credentialId from local storage.
  • Ensured credentialId is set to undefined if not available.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:02am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:02am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:02am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:02am

Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: 678bca7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

graphite-app bot commented Oct 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges marked this pull request as ready for review October 29, 2024 00:36
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 457 ms (+85.8% 🔺) 1.4 s
thirdweb (cjs) 102.91 KB (0%) 2.1 s (0%) 858 ms (+15.34% 🔺) 3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 29 ms (-60.4% 🔽) 126 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 157 ms (+1775.64% 🔺) 167 ms
thirdweb/react (minimal + tree-shaking) 17.38 KB (0%) 348 ms (0%) 127 ms (+128.94% 🔺) 475 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant