Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Debian Buster Dockerfile #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m1k1o
Copy link
Contributor

@m1k1o m1k1o commented Mar 9, 2021

Switching from alpine to debian buster fixed my problem #37. Now it seems to fail, when i connect with UDP (strange!) I added it as separate Dockerfile, just as another option. Also, switching to TCP improved image quality.

Maybe releated issue: #46.

And then receiving stream using

ffmpeg -y \
    -rtsp_transport tcp \
    -fflags discardcorrupt \
    -i "rtsp://neolink:8554/cam/mainStream?fifo_size=500000000"

I don't get any video artifacts at all.

apt-get update; \
apt-get install -y --no-install-recommends \
build-essential \
musl-dev gcc \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't need musl-dev on a buster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without it, it didn't work.

Comment on lines +21 to +22
# Use static linking to work around https://github.com/rust-lang/rust/pull/58575
ENV RUSTFLAGS='-C target-feature=-crt-static'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this workaround only required on musl?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe because of this it didn't work without musl-dev. No idea.

RUN set -eux; \
apt-get update; \
apt-get install -y --no-install-recommends \
musl-dev \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev packages not need on publish image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without musl-dev I could not get it working. If you manage to get it out, it will be just great.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm odd. I should have my buster image on one of my branches. I'll dig it up in the morning and see what else is different.

@QuantumEntangledAndy
Copy link
Collaborator

QuantumEntangledAndy commented Mar 9, 2021

That's strange because of one of images I got you to test at the time was a buster. Maybe there has been an update upstream since then.

Anyways glad your issue is fixed because this one has been bugging me for ages.

@m1k1o
Copy link
Contributor Author

m1k1o commented Dec 10, 2022

Today I migrated my script to a different server, and tried the latest docker image. Still got the same problem. But after using this docker image, it complied flawlessly with latest code and works just right.

Just FYI, i had this script for last 1.5 years 24/7 in use and it worked flawlessly! I would suggest to replace default Dockerfile with this version, as this is proven to work and fixes #37 and #46.

@QuantumEntangledAndy
Copy link
Collaborator

If you want this merged might I recommend some changes.

1: remove the musl I can confirm they are not required (see QuantumEntangledAndy/#20)
2: Switch to slim-buster no need to use the larger buster image when the smaller one works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants