Skip to content

Commit

Permalink
xen: Remove unnecessary BUG_ON from __unbind_from_irq()
Browse files Browse the repository at this point in the history
Commit 910f8be ("xen/pirq: fix error path cleanup when binding
MSIs") fixed a couple of errors in error cleanup path of
xen_bind_pirq_msi_to_irq(). This cleanup allowed a call to
__unbind_from_irq() with an unbound irq, which would result in
triggering the BUG_ON there.

Since there is really no reason for the BUG_ON (xen_free_irq() can
operate on unbound irqs) we can remove it.

Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: stable@vger.kernel.org
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
  • Loading branch information
Boris Ostrovsky authored and jgross1 committed Jun 22, 2018
1 parent c51b3c6 commit eef04c7
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/xen/events/events_base.c
Original file line number Diff line number Diff line change
Expand Up @@ -628,8 +628,6 @@ static void __unbind_from_irq(unsigned int irq)
xen_irq_info_cleanup(info);
}

BUG_ON(info_for_irq(irq)->type == IRQT_UNBOUND);

xen_free_irq(irq);
}

Expand Down

0 comments on commit eef04c7

Please sign in to comment.