fix: 🏷️ fix incorrect units

thkruz · May 16, 2023 · d790d63 · d790d63
1 parent a372498
commit d790d63
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ootk",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "Orbital Object Toolkit including SGP4 Propagator and Coordinate Transforms",
   "main": "dist/ootk.js",
   "scripts": {

diff --git a/src/objects/sensor.ts b/src/objects/sensor.ts
@@ -230,8 +230,8 @@ export class Sensor extends BaseObject {
       const rae = this.getRae(sat, curTime);
 
       // Radians to Degrees
-      rae.az = <Degrees>((rae.az * 360) / TAU);
-      rae.el = <Degrees>((rae.el * 360) / TAU);
+      const azDeg = <Degrees>((rae.az * 360) / TAU);
+      const elDeg = <Degrees>((rae.el * 360) / TAU);
 
       const isInView = this.isRaeInFov(rae);
 
@@ -250,8 +250,8 @@ export class Sensor extends BaseObject {
         const pass = <Lookangles>{
           type,
           time: curTime,
-          az: rae.az,
-          el: rae.el,
+          az: azDeg,
+          el: elDeg,
           rng: rae.rng,
         };
 

diff --git a/src/objects/star.ts b/src/objects/star.ts
@@ -105,7 +105,7 @@ export class Star extends SpaceObject {
       this.dec,
     );
 
-    return { az: <Degrees>(starPos.az * RAD2DEG), el: <Degrees>(starPos.el * RAD2DEG), rng: <Kilometers>250000 };
+    return { az: starPos.az, el: starPos.el, rng: <Kilometers>250000 };
   }
 
   private static calculateTimeVariables(date: Date): { gmst: GreenwichMeanSiderealTime; j: number } {

diff --git a/src/transforms/transforms.ts b/src/transforms/transforms.ts
@@ -237,8 +237,8 @@ class Transforms {
    */
   public static sez2rae(sez: SezVec3): RaeVec3 {
     const rng = <Kilometers>Math.sqrt(sez.s * sez.s + sez.e * sez.e + sez.z * sez.z);
-    const el = <Degrees>Math.asin(sez.z / rng);
-    const az = <Degrees>(Math.atan2(-sez.e, sez.s) + PI);
+    const el = <Radians>Math.asin(sez.z / rng);
+    const az = <Radians>(Math.atan2(-sez.e, sez.s) + PI);
 
     return <RaeVec3>{
       rng,

diff --git a/src/types/types.ts b/src/types/types.ts
@@ -32,8 +32,8 @@ export type LlaVec3 = {
 };
 export type RaeVec3 = {
   rng: Kilometers;
-  az: Degrees;
-  el: Degrees;
+  az: Radians;
+  el: Radians;
 };
 export type SezVec3 = {
   s: Kilometers;