factor of rational numbers : StackOverflowError

[WimKlim]

I get (Julia version v1.9.0 Windows 64-Bit, Hecke version 0.18.14) :

julia> factor(12//35)
ERROR: StackOverflowError:
Stacktrace:
[1] factor(a::Rational{Int64}; b::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
@ Hecke xxx.julia\packages\Hecke\ttSxw\src\Misc\Integer.jl:712
[2] factor(a::Rational{Int64})
@ Hecke xxx.julia\packages\Hecke\ttSxw\src\Misc\Integer.jl:712
[3] factor(x::Rational{Int64})
@ Hecke xxx.julia\packages\Hecke\ttSxw\src\Hecke.jl:239--- the last 3 lines are repeated 26660 more times ---

[fieker]

On Mon, Jun 05, 2023 at 04:26:15AM -0700, WimKlim wrote: I get (Julia version v1.9.0 Windows 64-Bit, Hecke version 0.18.14) : julia> factor(12//35) ERROR: StackOverflowError: Stacktrace: [1] factor(a::Rational{Int64}; b::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}) @ Hecke xxx\.julia\packages\Hecke\ttSxw\src\Misc\Integer.jl:712 [2] factor(a::Rational{Int64}) @ Hecke xxx\.julia\packages\Hecke\ttSxw\src\Misc\Integer.jl:712 [3] factor(x::Rational{Int64}) @ Hecke xxx\.julia\packages\Hecke\ttSxw\src\Hecke.jl:239--- the last 3 lines are repeated 26660 more times --- -- Reply to this email directly or view it on GitHub: #1110 You are receiving this because you are subscribed to this thread. Message ID: ***@***.***>

Thanks! Btw, depending on your Nemo version, either julia> factor(QQ(12//35), ZZ) 1 * 5^-1 * 7^-1 * 2^2 * 3 or factor(ZZ, QQ(12//35)) should work. Apart from an error, what is the expected result? A factorisation over ZZ (with negative exponents) or one in the field (unit times empty factorisation)?

[WimKlim]

Thanks, factor(QQ(12//35), ZZ) works and is what I expect (ZZ (with negative exponents)) .
The Nemo version is 0.34.4 .

[fieker]

On Mon, Jun 05, 2023 at 06:26:08AM -0700, WimKlim wrote: Thanks, factor(QQ(12//35), ZZ) works and is what I expect (ZZ (with negative exponents)) . The Nemo version is 0.34.4 .

We're about the change the order of the arguments...

…

-- Reply to this email directly or view it on GitHub: #1110 (comment) You are receiving this because you commented. Message ID: ***@***.***>

[thofma]

We are missing the factor(x::Rational) = factor(QQ(x)) fallback and similar for the two-argument version.