Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preimage map of residue field #1285

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix preimage map of residue field #1285

merged 1 commit into from
Nov 14, 2023

Conversation

thofma
Copy link
Owner

@thofma thofma commented Nov 14, 2023

Fixes #1284

@thofma thofma closed this Nov 14, 2023
@thofma thofma reopened this Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #1285 (30833a3) into master (d65dbb3) will decrease coverage by 0.03%.
Report is 4 commits behind head on master.
The diff coverage is 81.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1285      +/-   ##
==========================================
- Coverage   74.58%   74.55%   -0.03%     
==========================================
  Files         346      346              
  Lines      111379   111383       +4     
==========================================
- Hits        83070    83046      -24     
- Misses      28309    28337      +28     
Files Coverage Δ
src/Map/NfOrd.jl 66.75% <100.00%> (+0.08%) ⬆️
src/Misc/Integer.jl 49.33% <100.00%> (-0.29%) ⬇️
src/Misc/jordan.jl 58.04% <100.00%> (+0.22%) ⬆️
src/NumField/QQ.jl 53.12% <100.00%> (+1.92%) ⬆️
src/GrpAb/GrpAbFinGen.jl 80.39% <0.00%> (-0.10%) ⬇️
src/QuadForm/Quad/NormalForm.jl 99.55% <50.00%> (-0.15%) ⬇️

... and 26 files with indirect coverage changes

@thofma thofma merged commit 60a055c into master Nov 14, 2023
29 of 34 checks passed
@thofma thofma deleted the th/mark2 branch November 14, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with residue_field
1 participant