Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kernel(::SMat) better infereable #1633

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

lgoettgens
Copy link
Contributor

Without this change, the compiler only infers Union{dense_matrix_type(C), Nothing}, as it does not know that the if/elseif clause get always taken due to the check in the beginning. Adding this explicit error removes Nothing from the possible return types.

src/Sparse/Rref.jl Outdated Show resolved Hide resolved
Co-authored-by: Johannes Schmitt <jschmitt@posteo.eu>
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.81%. Comparing base (a024dc6) to head (f0ecd81).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1633      +/-   ##
==========================================
- Coverage   75.85%   75.81%   -0.05%     
==========================================
  Files         361      361              
  Lines      113702   113701       -1     
==========================================
- Hits        86249    86201      -48     
- Misses      27453    27500      +47     
Files with missing lines Coverage Δ
src/Sparse/Rref.jl 99.07% <100.00%> (-0.01%) ⬇️

... and 24 files with indirect coverage changes

@thofma thofma merged commit 1d7dfe9 into thofma:master Oct 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants