Remove submitter function and type. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davezuch
reviewed
Sep 10, 2018
example/basic/Component.purs
Outdated
| { name :: String | ||
| , text :: String | ||
| } | ||
| type Contact = { name :: String, text :: String } | ||
|
|
||
| newtype Form r f = Form (r |
There was a problem hiding this comment.
Would it be clearer to call this UserForm? Especially now that we've taken User out of the Formless type signatures
There was a problem hiding this comment.
Yea, renaming to ContactForm is for the best. Thanks!
davezuch
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Removes the
submitterfunction andouttype from the component for simplicity. For further details:Resolves #21
Where should the reviewer start?
Review changes to the Formless component and to how the
Submittedmessage is handled in each example file.Other Notes:
I'll leave this PR open until tomorrow for comments.