Add ability to set or modify input values, instead of only set. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucture modules to more accurately reflect names and uses of functions and for clarity.
thomashoneyman
commented
Oct 20, 2018
| @@ -160,9 +160,9 @@ formlessField | |||
| . IsSymbol sym | |||
| => ToText e | |||
| => Newtype (form Record F.FormField) (Record fields) | |||
| => Newtype (form Variant F.InputField) (Variant inputs) | |||
| => Newtype (form Variant F.InputFunction) (Variant inputs) | |||
There was a problem hiding this comment.
@dariooddenino Helper classes that previously used the InputField variant will need to be updated to use the InputFunction variant instead, the only class on the component. The variant was changed to support InputFunction (input -> input) and modification.
thomashoneyman
commented
Oct 20, 2018
| @@ -72,7 +72,7 @@ renderEnabled state = | |||
| [ css "checkbox" | |||
| , HP.type_ InputCheckbox | |||
| , HP.checked $ F.getInput prx.enable state.form | |||
| , HE.onChange $ HE.input_ $ F.modify prx.enable (not $ F.getInput prx.enable state.form) | |||
| , HE.onChange $ HE.input_ $ F.modify prx.enable not | |||
There was a problem hiding this comment.
These sorts of "toggle" functions are now possible in Formless @whoadave @crcornwell
thomashoneyman
commented
Oct 20, 2018
| ModifyValidateInput variant a -> do | ||
| st <- getState | ||
| let form = Internal.unsafeModifyInputVariant variant st.form | ||
| form' <- do |
There was a problem hiding this comment.
This has been updated to minimize state updates / re-renders by not calling out to the Modify or Validate queries
* Added helper queries for all public queries. Added SetAll and ModifyAll functions. Broke something... * Fix instances * Update examples. Rename replaceInputs to initialize to better reflect its purpose and function. * Fix formatting * Add wrapInputFunctions helper function. Add documentation to wrap* and unwrap* helpers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Formless currently allows users to set the value of a form field with the
Modifyquery. This is a curiously-named query given that it is really a way to set a field, and there is no support for users who would like to apply a function to the form field instead.This PR updates the library to distinguish between setting a field (
field -> input -> field) or modifying it (field -> (input -> input) -> field). TheModify*family of queries all behave as true modifications now, with the previous setting behavior easily recovered usingconst. A new helper query,set, has been introduced to make this easy and be a drop-in replacement for how themodifyquery previously worked.This also closes #32 by allowing you to force validation on a field that hasn't been touched yet -- simply do:
to set the field touched and run validation.
Additional Changes
In addition, this PR reworks the module structure of the library to achieve a few goals:
Specno longer has any relation to the concept of a "form spec" and has been renamedTypes.Form)The new structure has no breaking changes for any user who previously did
import Formless as F, as all modules are still re-exported. However, users who imported from multiple modules will need to update their code to the new module names.Other Notes:
The project documentation will need to be updated to reflect the new
setandmodifycapabilities of the library and the new locations of modules. The release notes for the 0.3.0 release must include a section describing what modules and functions have been moved so that users are able to migrate easily.