Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running betteralign on the project code #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thomasjungblut
Copy link
Owner

$ betteralign -apply ./...
/skiplist/map_generic.go:138:24: 16 bytes saved: struct with 40 pointer bytes could be 24
/pq/priority_queue.go:27:37: 8 bytes saved: struct with 56 pointer bytes could be 48
/pq/priority_queue.go:34:43: 24 bytes saved: struct with 48 pointer bytes could be 24
/recordio/bufio_vendor.go:23:13: 24 bytes saved: struct with 64 pointer bytes could be 40
/recordio/bufio_vendor.go:129:13: 32 bytes saved: struct with 72 pointer bytes could be 40
/recordio/common_reader.go:11:13: 8 bytes saved: struct with 24 pointer bytes could be 16
/recordio/file_reader.go:12:17: 16 bytes saved: struct with 56 pointer bytes could be 40
/recordio/file_writer.go:21:17: 8 bytes saved: struct of size 104 could be 96
/recordio/file_writer.go:209:24: 8 bytes saved: struct with 24 pointer bytes could be 16
/recordio/mmap_reader.go:12:17: 8 bytes saved: struct with 40 pointer bytes could be 32
/recordio/proto/proto_writer.go:46:20: 8 bytes saved: struct with 24 pointer bytes could be 16
/sstables/sstable_merger.go:12:34: 8 bytes saved: struct with 24 pointer bytes could be 16
/sstables/sstable_reader.go:296:27: 8 bytes saved: struct with 32 pointer bytes could be 24
/sstables/sstable_writer.go:245:27: 56 bytes saved: struct with 80 pointer bytes could be 24
/sstables/super_sstable_reader.go:12:25: 16 bytes saved: struct with 40 pointer bytes could be 24
/memstore/memstore.go:62:15: 8 bytes saved: struct of size 32 could be 24
/wal/appender.go:13:15: 16 bytes saved: struct with 64 pointer bytes could be 48
/wal/write_ahead_log.go:96:14: 16 bytes saved: struct with 40 pointer bytes could be 24
/simpledb/db.go:63:9: 56 bytes saved: struct with 176 pointer bytes could be 120
/simpledb/sstable_manager.go:15:21: 16 bytes saved: struct with 88 pointer bytes could be 72
/simpledb/porcupine/db_recorder.go:10:29: 8 bytes saved: struct with 32 pointer bytes could be 24
/simpledb/porcupine/model.go:25:12: 8 bytes saved: struct with 32 pointer bytes could be 24
/simpledb/porcupine/model.go:31:13: 8 bytes saved: struct with 48 pointer bytes could be 40

@@ -49,7 +49,6 @@ type MemStoreI interface {
// Size Returns how many elements are in this memstore. This also includes tombstoned keys.
Size() int
}

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't seem CRLF proof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant