Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svg output #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

jcolafrancesco
Copy link
Contributor

Fixing two issues on top of master:

  • compilation issue into the schematic reader
  • Changing output extension doesn't have any effect

Then, adding SVG output format, here is the result on a medium complexity schematic:
Screenshot from 2024-05-25 08-45-39

Copy link

sonarcloud bot commented May 25, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

thomaslepoix

This comment was marked as duplicate.

@thomaslepoix
Copy link
Owner

Despite being unable to rebase your branch on master to resolve conflicts, I cherry-picked your commits and updated those while reviewing.

Correct scaling seems tricky with SVG, I managed to print a correctly scaled board by exporting and then, opening the SVG in Inkscape and setting the page size to my paper size (A4) in the document properties, before sending to the printer.

Could you confirm you can produce accurately sized boards in the context of your CNC workflow?

@jcolafrancesco
Copy link
Contributor Author

Quick question: how bad was the scaling effect? Less than 10% or something even more out of the road?

@thomaslepoix
Copy link
Owner

It seems to me that if the document size matches the actual paper size, the printer manages to print the image as wanted. If both don't match, my printer seems to perform some random scaling of the image to fit the paper size (like x1.5 in my test case)

So I am wondering if a CNC is subject to such resizing specificity as I am not familiar with the workflow.

@jcolafrancesco
Copy link
Contributor Author

Can you share your file with the expected measurements?
I'll test in UGS to visualize how it interpret this SVG. If the rendered dimensions are good within the preview, I think we're good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants