Skip to content
This repository has been archived by the owner on Jun 29, 2021. It is now read-only.

"Fix" for issue #11 #14

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

"Fix" for issue #11 #14

wants to merge 8 commits into from

Conversation

freemann
Copy link

Make overlay bigger and centre icon in new overlay.

Make overlay bigger and centre icon in new overlay.
Added option for user set delayed unlock
Added option for user set delayed relock
Added option for icon color change for unlock delay notice.
@thomasloven
Copy link
Owner

Thank you!
I've been giving this plugin much too little love for far too long...

Please add the new options to the readme, and fix the missing newline at the end of the file too, and then it'll be good to merge.
Maybe make the indentation consistent too, btw.

Updating readme.md/fix indent
@freemann
Copy link
Author

freemann commented Oct 15, 2019

Please let me know your thoughts about my last commit, hopefully its meets your requirements.

Maybe adding a hacs.json and some versioning (tags)?!

@thomasloven
Copy link
Owner

Is this ok with you?

About the hacs.json, my sources tell me that there's something better than toggle-lock-entity-row coming soon, so I'd rather hold on that for a while.

@freemann
Copy link
Author

freemann commented Oct 15, 2019

You got me curious....

Pull request looks good to me.

For what it's worth, here's a gif with the new unlocking delay.
switchlockdelay

@andriej
Copy link

andriej commented Jan 3, 2020

@thomasloven your sources are wrong, I still recommend yours version as much simplier for new users to integrate - and frankly it's harder for them to get as there's no hacs.json ;-)

@thomasloven
Copy link
Owner

Are they?

@andriej
Copy link

andriej commented Jan 6, 2020

Isn't your simplier and thus lighter if people like me need only simple lock on entity? ;-)

@thomasloven
Copy link
Owner

Marginally, but restriction-card is more up to date, has more features and is available in hacs.

I see no reason to keep maintaining toggle-lock-entity-row for a subset of the functionality of restriction-card.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants