Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode Sparkplug Longs to Numbers #712

Closed
wants to merge 0 commits into from

Conversation

AlexGodbehere
Copy link

@AlexGodbehere AlexGodbehere commented Mar 21, 2023

I've been using this version of the application locally for some time and figured it may be useful upstream. The primary change ensures that Long values are decoded into Numbers when using Sparkplug payloads.

Before:

{
  "timestamp": {
    "low": 55640321,
    "high": 391,
    "unsigned": true
  },
}

After:

{
  "timestamp": 1679387932588
}

Other Changes

  • Update to Node 19
  • This may be quite opinionated, but I've also made the value window automatically expand to the full size of the message to reduce scrolling

@AlexGodbehere AlexGodbehere changed the title Decode sparkplug Longs to Numbers Decode Sparkplug Longs to Numbers Mar 21, 2023
@bj00rn
Copy link
Collaborator

bj00rn commented Apr 2, 2024

@AlexGodbehere could you rebase this PR on master please, and give it some testing and ill try to get it merged.

I had to refactor sparkplug.proto into a js const since the file was not included in packaging and broke binaries.

Thanks

@bj00rn
Copy link
Collaborator

bj00rn commented May 2, 2024

duplicate of #727?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants