Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove migrationcli code and relevant makefile code #2457

Merged

Conversation

Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Oct 6, 2024

Description

Remove migrationcli code and any relevant commands as they will no longer work too.

Closes issue(s)

Resolve #2402

Checklist

  • I have tested this code - unit tests pass (integrations tests have errors but its expected I think)
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 7bf5df7
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6704eaf957222500081974c6

@Light2Dark Light2Dark changed the title clean: remove migrationcli code and relevant make code chore: remove migrationcli code and relevant make code Oct 6, 2024
@Light2Dark Light2Dark changed the title chore: remove migrationcli code and relevant make code chore: remove migrationcli code and relevant makefile code Oct 6, 2024
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.55%. Comparing base (1bae773) to head (7bf5df7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2457      +/-   ##
==========================================
- Coverage   85.74%   85.55%   -0.20%     
==========================================
  Files         102      100       -2     
  Lines        3606     3523      -83     
==========================================
- Hits         3092     3014      -78     
+ Misses        390      386       -4     
+ Partials      124      123       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.
I will merge it a bit later after the issue #2401 will be merged.

Copy link

sonarcloud bot commented Oct 8, 2024

@thomaspoignant thomaspoignant merged commit 6442dd8 into thomaspoignant:main Oct 8, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove migration cli code
2 participants