Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update S3 client initialization for retriever and exporter #2480

Conversation

hoangnv-bkhn
Copy link
Contributor

Description

  • Problem:
    When the S3 client is initialized for retrievers and exporters, the application does not allow the user to further configure how the S3 client should behave. (It currently only accepts AwsConfig as a parameter).
  • The way it was resolved:
    Add an optional field to the Retriever/Exporter structure
    Use this field when initializing the S3 client
  • How to test the change:
    Refer to the options that AWS allows to configure here and implement the appropriate custom functions.

Closes issue(s)

Resolve #2451

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 22274d4
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/67067ec899143000099f028d

@hoangnv-bkhn hoangnv-bkhn changed the title feat: update S3 client initialization feat: update S3 client initialization for retriever and exporter Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.18%. Comparing base (012659f) to head (22274d4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2480   +/-   ##
=======================================
  Coverage   86.18%   86.18%           
=======================================
  Files         100      100           
  Lines        3526     3526           
=======================================
  Hits         3039     3039           
  Misses        360      360           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition, this is really great to have a more extensible s3 integration.

Copy link

sonarcloud bot commented Oct 9, 2024

@thomaspoignant thomaspoignant merged commit a50e1d7 into thomaspoignant:main Oct 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(change) Change the way the S3 client is instantiated in the exporter/retriever
2 participants