Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused symlink #2486

Merged
merged 1 commit into from
Oct 9, 2024
Merged

chore: remove unused symlink #2486

merged 1 commit into from
Oct 9, 2024

Conversation

thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Oct 9, 2024

Description

Remove cmd/server symlink that is un-used.

Note

At some point we wanted to get rid of the name relay-proxy and rather call it go-feature-flag server.
But now the name is well adopted now, so I think it is ok to remove the symlink.

Closes issue(s)

Resolve #2484

Checklist

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 384eda2
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6706d297cb10d60008702478

Copy link

sonarcloud bot commented Oct 9, 2024

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.18%. Comparing base (a50e1d7) to head (384eda2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2486   +/-   ##
=======================================
  Coverage   86.18%   86.18%           
=======================================
  Files         100      100           
  Lines        3526     3526           
=======================================
  Hits         3039     3039           
  Misses        360      360           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 5179a2a into main Oct 9, 2024
25 checks passed
@kodiakhq kodiakhq bot deleted the remove-server-symlink branch October 9, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(question) Why is there a cmd/server directory symlinked to cmd/relayproxy?
1 participant