-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add config to allow surpressing notification on launch (flag cache load) #2534
base: main
Are you sure you want to change the base?
Conversation
…nOnInit is set to true
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2534 +/- ##
==========================================
+ Coverage 85.84% 85.90% +0.06%
==========================================
Files 100 100
Lines 3554 3577 +23
==========================================
+ Hits 3051 3073 +22
- Misses 378 379 +1
Partials 125 125 ☔ View full report in Codecov by Sentry. |
This also aligns the interval with rest of the test code
Quality Gate passedIssues Measures |
Description
This pull request introduces a new feature to disable notifications on initialization and refactors the caching mechanism to support this feature. It also includes updates to the test suite to ensure the new functionality works as expected.
Problem
Resolution
DisableNotificationOnInit
configuration key. If set to true, avoid sending the notification on cache initialization (it will still send notification when the change is detected AFTER initialization)How to test
go test ./...
ffClient
should do the trick too.Closes issue(s)
Resolve #2532
Checklist
README.md
and/website/docs
)