Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XCLASS FormController #29

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

sypets
Copy link
Contributor

@sypets sypets commented Dec 10, 2024

todo:


There was a conflict with powermail_cleaner because both extensions XCLASSed FormController.

Resolvers: #28

todo:

* [ ] Requires method to add a variable to the view in the EventListener

There was a conflict with powermail_cleaner because both extensions
XCLASSed FormController.

Resolvers: thomasrawiel#28
@sypets sypets marked this pull request as draft December 10, 2024 18:00
@thomasrawiel thomasrawiel marked this pull request as ready for review December 10, 2024 22:52
@sypets sypets marked this pull request as draft December 11, 2024 17:51
- Add Services.yaml
- check if method exists in event first
- use method "assign"
- check if function exists, to be safe
- use different event method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant