EquivalentTo Struct Fix (#1384)

thomhurst · Dec 10, 2024 · 0a00c94 · 0a00c94
1 parent 6bc8d8f
commit 0a00c94
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/TUnit.Assertions.UnitTests/EquivalentAssertionTests.cs b/TUnit.Assertions.UnitTests/EquivalentAssertionTests.cs
@@ -232,6 +232,37 @@ public async Task Objects_With_Nested_Matches_Are_Equivalent()
         await TUnitAssert.That(object1).IsEquivalentTo(object2);
     }
 
+    [Test]
+    public async Task Struct_Objects_With_Nested_Matches_Are_Equivalent()
+    {
+        var object1 = new MyStruct
+        {
+            Value = "Foo",
+            Inner = new InnerClass
+            {
+                Value = "Bar",
+                Inner = new InnerClass
+                {
+                    Value = "Baz"
+                }
+            }
+        };
+        var object2 = new MyStruct
+        {
+            Value = "Foo",
+            Inner = new InnerClass
+            {
+                Value = "Bar",
+                Inner = new InnerClass
+                {
+                    Value = "Baz"
+                }
+            }
+        };
+
+        await TUnitAssert.That(object1).IsEquivalentTo(object2);
+    }
+
     [Test]
     public void Objects_With_Nested_Enumerable_Mismatch_Are_Not_Equivalent()
     {
@@ -359,4 +390,10 @@ public class InnerClass
 
         public IEnumerable<string>? Collection { get; set; } 
     }
+
+    public struct MyStruct
+    {
+        public string? Value { get; set; }
+        public InnerClass? Inner { get; set; }
+    }
 }
diff --git a/TUnit.Assertions/Compare.cs b/TUnit.Assertions/Compare.cs
@@ -61,7 +61,6 @@ private static IEnumerable<ComparisonFailure> CheckEquivalent<
 
         if (actual.GetType().IsPrimitive
             || actual.GetType().IsEnum
-            || actual.GetType().IsValueType
             || actual is string)
         {
             yield return new ComparisonFailure